-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Components: Button, Chip and Tooltip #204
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor thing, but for isSmall
can we add vertical padding of 2px
For both, can we make the trigger have borderRadius: 1
and change the trigger width to 8px
@benkolde What is the trigger? did you mean the arrow? I made the arrow 8px dimension now but I dont know how border radius would affect it |
I just want the arrow to look like this |
@benkolde @ida-strom this is ready for re-review. One thing I noticed is that the tooltip extends to the width of the Trigger element, if wrongly set or unchecked it can go very wide. I suggest putting a |
Can this be a prop? @daigof I think having the option for it to expand would be great |
Can you build a new test environment for this? |
@benkolde I added a new optional prop for restricted width (327px) with default false value so it doesn't impact existing implementations. Deployed a review app here https://curology-radiance-pr-204.herokuapp.com/ |
@benkolde Updated the border radius of small tooltip to 4px. https://curology-radiance-pr-204.herokuapp.com/?path=/story/tooltip--usage |
isSmall
prop for smaller tooltips.Other minor fixes
display: inline-text
instead ofwidth:content-fit
Preview link
https://curology-radiance-pr-204.herokuapp.com/