Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update components: Alert, Banner, Field, BulkErrors #208

Merged
merged 11 commits into from
Mar 23, 2020

Conversation

daigof
Copy link
Contributor

@daigof daigof commented Mar 20, 2020

- Alert:

  • updated styles
  • bolded text (optional),
  • avatar image (optional),
  • cta content (optional),
  • cut text beyond 2 lines (...)
  • updated docs and story

- Banner: updated styles similar to alerts, updated docs and story

- New VerificationMessages Components (replaces BulkErrors):

  • This is a separate component used inside Field so for errors and success messages lines new stylings is done there
  • updated docs and story

- Field:

  • Support for success messages so error prop is no longer used instead you use messages and messagesType
  • Removed all bottom spacing that allowed slide down animation to happen without moving below fields.
  • Now Field has a fixed margin bottom of 24px. Hints and errors still slide down fine.
  • Optional bolded text now
  • updated docs and story

Review app: https://curology-radiance-pr-208.herokuapp.com/

- Other Fixes: Fixed Accordion knobs leaking in all other components.

@snags88 snags88 temporarily deployed to curology-radiance-pr-208 March 20, 2020 14:58 Inactive
@snags88 snags88 temporarily deployed to curology-radiance-pr-208 March 20, 2020 19:53 Inactive
@snags88 snags88 temporarily deployed to curology-radiance-pr-208 March 23, 2020 12:56 Inactive
@snags88 snags88 temporarily deployed to curology-radiance-pr-208 March 23, 2020 14:44 Inactive
@snags88 snags88 temporarily deployed to curology-radiance-pr-208 March 23, 2020 14:59 Inactive
Copy link
Contributor

@benkolde benkolde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@daigof the only thing I can see is with the CTA alert border, can we make it have an opacity of 0.1? So it looks like a faint white line. Other than that these look GTM! 👍

@daigof daigof merged commit 7b237e3 into master Mar 23, 2020
@daigof daigof deleted the update-alert-banner-field branch March 23, 2020 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants