Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move breakpoints into its own constant file #3

Merged
merged 1 commit into from
Oct 31, 2018
Merged

move breakpoints into its own constant file #3

merged 1 commit into from
Oct 31, 2018

Conversation

snags88
Copy link
Contributor

@snags88 snags88 commented Oct 30, 2018

Didn't notice the breakpoints inside of the MEDIA_QUERIES constant was being exported and used in our main repo. This puts breakpoints in its own constant file so it's easier to import

Storybook automagically updated:
screen shot 2018-10-30 at 4 29 54 pm

@snags88 snags88 self-assigned this Oct 30, 2018
ZeMunchkin
ZeMunchkin approved these changes Oct 31, 2018
View reviewed changes
Copy link
Contributor

@ZeMunchkin ZeMunchkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense! 👍

@snags88 snags88 merged commit bc2ea1e into master Oct 31, 2018
@snags88 snags88 deleted the add-breakpoints-const branch October 31, 2018 02:14
@snags88 snags88 mentioned this pull request Sep 19, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZeMunchkin ZeMunchkin ZeMunchkin approved these changes

Assignees

@snags88 snags88

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@snags88 @ZeMunchkin