Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TS conversion] Callout and Carousel #300

Merged
merged 4 commits into from
Aug 10, 2020
Merged

[TS conversion] Callout and Carousel #300

merged 4 commits into from
Aug 10, 2020

Conversation

daigof
Copy link
Contributor

@daigof daigof commented Aug 6, 2020 •
edited
Loading

Convert Callout and Carousel component to TS.
Fix some eslint issues

@snags88 snags88 temporarily deployed to curology-radiance-pr-300 August 6, 2020 17:51 Inactive
@snags88 snags88 temporarily deployed to curology-radiance-pr-300 August 6, 2020 19:26 Inactive
@daigof daigof changed the title [TS conversion] Callout [TS conversion] Callout and Carousel Aug 7, 2020
@daigof daigof requested review from a team and jenniferhm and removed request for a team August 7, 2020 19:03
jenniferhm
jenniferhm approved these changes Aug 7, 2020
View reviewed changes
Copy link
Contributor

@jenniferhm jenniferhm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@daigof daigof merged commit 84cd503 into master Aug 10, 2020
@daigof daigof deleted the ts-convertion2 branch August 10, 2020 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jenniferhm jenniferhm jenniferhm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@daigof @jenniferhm @snags88