[a11y] Fix dropdown aria-label and ID #307
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After upgrading to the WCAG 2.1 standard in our Cypress test, there was an issue raised with the dropdown component's aria-label. The 2.1 standard includes a rule that the text of an element should be contained within the
aria-label
https://dequeuniversity.com/rules/axe/3.5/label-content-name-mismatch?application=axeAPI Thearia-label
I was using on the component was too generic. I tested this using a screen reader and actually found that it worked well without thearia-label
, because therole
andhaspopup
attributes made it reasonably clear the intention. More user testing would be required to be sure, but for now I'd rather have lessaria
information than incorrect information.In addition, I removed the
id
from the Dropdown. There are some places where we render multipleDropdown
components, which leads to theid
not being unique.