Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Dependencies] Bump @emotion packages #323

Merged
merged 5 commits into from
Aug 28, 2020
Merged

[Dependencies] Bump @emotion packages #323

merged 5 commits into from
Aug 28, 2020

Conversation

michaeljaltamirano
Copy link
Contributor

@michaeljaltamirano michaeljaltamirano commented Aug 27, 2020 •
edited
Loading

  1. We've been out of date for these dependencies for some time now, and updating them in any usage apps requires versions be identical.
  2. I added the specific versions as peerDependencies for this reason so we'll see in CLI build output if stuff is out of sync. I'm happy to pull this back and just rely on jest snapshot output in the main app to determine if there are issues. It might be nice to handcuff ourselves a bit, though.

@snags88 snags88 temporarily deployed to curology-radiance-pr-323 August 27, 2020 19:37 Inactive
@snags88 snags88 temporarily deployed to curology-radiance-pr-323 August 27, 2020 19:42 Inactive
@snags88 snags88 temporarily deployed to curology-radiance-pr-323 August 27, 2020 20:05 Inactive
daigof
daigof approved these changes Aug 28, 2020
View reviewed changes
Copy link
Contributor

@daigof daigof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok storybook doesnt seem to be affected 👍

@michaeljaltamirano michaeljaltamirano merged commit 8f3521f into master Aug 28, 2020
@michaeljaltamirano michaeljaltamirano deleted the dependencies/emotion branch August 28, 2020 18:13
@michaeljaltamirano michaeljaltamirano mentioned this pull request Sep 18, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daigof daigof daigof approved these changes

@youngmanalive youngmanalive youngmanalive approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@michaeljaltamirano @daigof @youngmanalive @snags88