Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Theming] Convert Components (Part III) #476

Merged
merged 8 commits into from
Oct 29, 2020
Merged

[Theming] Convert Components (Part III) #476

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
da0fd4c
Update global styles and storybook preview configuration
michaeljaltamirano Oct 29, 2020
9df6d7e
Update Callout, Chip, LoadingSpinner, and ProgressBar
michaeljaltamirano Oct 29, 2020
af9ed2e
Update DialogModal, Tabs, and Toggle
michaeljaltamirano Oct 29, 2020
3c8e5de
Update Dropdown
michaeljaltamirano Oct 29, 2020
f617f7f
Update SelectorButton styles, modify eslint rule
michaeljaltamirano Oct 29, 2020
9fac8fc
Convert COntainer, ImmersiveModal, OptionButton
michaeljaltamirano Oct 29, 2020
1d72269
Last commits: Container and Field, and update .size-snapshot
michaeljaltamirano Oct 29, 2020
82e3b4e
Rename prop to get off DOM
michaeljaltamirano Oct 29, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .eslintrc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,12 @@
}
],
"no-use-before-define": "off",
"object-curly-newline": [
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll want to update eslint-config-curology eventually, and/or add eslint-plugin-prettier since --fix overwrites our prettier rules, which typically occurs with 4 imports being broken into multiple lines even though the character limit does not exceeded our prettier settings.

"warn",
{
"ObjectPattern": { "multiline": false }
}
],
"react/jsx-filename-extension": [
"warn",
{
Expand Down
Loading