[Icons] Add clipboard #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Yihwan
commented
Feb 6, 2019
Yihwan
commented
snags88
suggested changes
Feb 6, 2019
src/svgs/icons/clipboard-icon.svg
Outdated
| @@ -0,0 +1,8 @@ | |||
| <svg width="16" height="16" viewBox="0 0 16 16" fill="none" xmlns="http://www.w3.org/2000/svg"> | |||
There was a problem hiding this comment.
no need to specify width and height on all the tags. The view box will take care of it and it'll allow us to scale the SVG when we use it
There was a problem hiding this comment.
seems to work now:
removed mask and g tags and other misc seemingly unnecessary info.
|
Investigating why icon seems to be smaller and lighter than others:
|
snags88
approved these changes
Feb 6, 2019
|
Just going to add that if you need to use this on the main app and it hasn't been fully converted to emotion 10 yet, you'll also need to merge this into the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.