[Theming] Add TYPOGRAPHY_CONSTANTS #520
Conversation
|
|
||
| export const primaryTheme = { | ||
| __type: 'primary', | ||
| BOX_SHADOW: {}, | ||
| COLORS: PRIMARY_COLORS, | ||
| FONTS: PRIMARY_FONTS, | ||
| TYPOGRAPHY: PRIMARY_TYPOGRAPHY, |
There was a problem hiding this comment.
Went with just TYPOGRAPHY instead of TYPOGRAPHY_CONSTANTS since we're accessing it off the theme now, so it is more obvious they are constants: there's no need to distinguish between TYPOGRAPHY and TYPOGRAPHY_CONSTANTS since they're not being imported from the same place like we currently do.
| @@ -1,9 +1,11 @@ | |||
| import PRIMARY_COLORS from '../colors/primary'; | |||
| import PRIMARY_FONTS from '../fonts/primary'; | |||
| import { PRIMARY_TYPOGRAPHY } from '../typography/primaryTypography'; | |||
There was a problem hiding this comment.
In general I think named exports are preferable
| @@ -0,0 +1,19 @@ | |||
| // TODO: Update when values are finalized | |||
There was a problem hiding this comment.
Keeping the values the same for now, rather than do empty strings like we are for Colors.
| @@ -0,0 +1,18 @@ | |||
| const fontSize = { | |||
There was a problem hiding this comment.
These values are duplicated from src/constants/typography/index because I don't think we should be wrapping them in throwOnUndefinedProperty. The value-add is less certain the more we have converted over to TS.
What & Why
compareObjectsKeysLengthhelper to include support for nested objects, along with error messages for why the test failed:- Objects of different lengths:
- Objects of same length with non-matching keys:
primaryThemeandsecondaryThemehaving the same keys