Fix Arrow svg to support theme #580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaeljaltamirano
approved these changes
Dec 1, 2020
There was a problem hiding this comment.
Thanks for cleaning up the unused classname too. Must've been a Figma copy-paste artifact of some sort.
Longer-term I think we should document this arrow in Figma, so we should let Ben know that this was moved outside of Tooltip to be its own icon, so that Design can be aware of this usage too.
I believe the visual regression test will fail now, because instead of purple it will be darker. Feel free to resolve as you see fit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
context #579
I branched that of secondary-theme PR so it was not clean this merges to master directly, besides I removed one unnecessary class in the svg path