Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Modals] - Update overlay color for both modals #846

Merged
merged 2 commits into from
Mar 9, 2021
Merged

[Modals] - Update overlay color for both modals #846

merged 2 commits into from
Mar 9, 2021

Conversation

daigof
Copy link
Contributor

@daigof daigof commented Mar 9, 2021

Made overlay Theme aware. Approved by Ben.

@daigof daigof requested a review from joeyquarters March 9, 2021 18:21
joeyquarters
joeyquarters approved these changes Mar 9, 2021
View reviewed changes
Copy link
Contributor

@joeyquarters joeyquarters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good, tested it out locally via Storybook.

It would be nice to add snapshot tests for the Immersive Modal, but that's not something we need to tackle in this PR.

@snags88 snags88 requested a deployment to curology-radiance-pr-846 March 9, 2021 19:01 Abandoned
@daigof daigof merged commit 8b37c2f into master Mar 9, 2021
@daigof daigof deleted the overlay-color-modals branch March 9, 2021 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joeyquarters joeyquarters joeyquarters approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@daigof @joeyquarters @snags88