Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Typography] Add Body Bold Typography #884

Merged
merged 1 commit into from
Mar 30, 2021

Conversation

michaeljaltamirano
Copy link
Contributor

@michaeljaltamirano michaeljaltamirano commented Mar 25, 2021

Fixes #808

non-breaking change but we'll want code changes in BuyNowCard.Title in userland.

@@ -43,6 +43,12 @@ const bodyStyle = (theme: ThemeType) => `
${baseBodyStyles(theme)}
`;

const bodyBoldStyle = (theme: ThemeType) => `
${bodyStyle(theme)}
font-weight: ${theme.TYPOGRAPHY.fontWeight.bold};
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

font-weight added for direct css usage if we need to use it instead of Typography.Bold (which is <strong>)

@michaeljaltamirano
Copy link
Contributor Author

Will merge in after next major release, since this can be a minor.

@michaeljaltamirano michaeljaltamirano merged commit 823433a into master Mar 30, 2021
@michaeljaltamirano michaeljaltamirano deleted the typography/body-bold branch March 30, 2021 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add "Body Bold" Typography
2 participants