[Styles] Prefer Anonymous Default Export Pattern #903
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mponent as sibling to others
| @@ -2,26 +2,17 @@ import React from 'react'; | |||
| import PropTypes from 'prop-types'; | |||
| import { useTheme } from 'emotion-theming'; | |||
|
|
|||
| import Loader from './shared-components/loader'; | |||
There was a problem hiding this comment.
Only change in this file is the relative import paths changing, and removing the importing/exporting of other non-Button buttons
| @@ -1,8 +1,8 @@ | |||
| import React from 'react'; | |||
|
|
|||
| import { RoundButton } from '../../button'; | |||
| import { RoundButton } from '../../button/components/roundButton'; | |||
There was a problem hiding this comment.
These changes incidentally make exports like this clearer, too
daigof
reviewed
Apr 1, 2021
daigof
approved these changes
Apr 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
export conststyled component exports to conform to our anonymousexport defaultpreference.radiance-uiis that anyone can import these styled components directly fromradiance-ui/lib. This change requires people to import the style file default export first, which makes it less likely people will do that.src/shared-components/button. Right now it's disorderly: the Button component itself imports (and exports) the other Button components, its style file is mostly shared styles, and anecdotally making changes to these components is always thorny due to the interconnectedness./componentssub-directory, to be a sibling of our other Button-like components. It maintains files atsrc/shared-components/buttonfor shared styles and types, and exports the 5 buttons thatsrc/shared-components/index.tsalso exports to make it available to the bundle.The size changes in the bundle is mostly because the non-production source map slug is longer (in the Accordion, it's 5066 characters vs. 4950), which wouldn't be reflected in our production bundles. Rollup also moves the anonymous default export into a
var Styledeclaration that creates a tiny bit of additional overhead.Due to the changing export pattern, releasing this will require a breaking change in order to also remove imports like
import { OuterContainer } from 'radiance-ui/lib/shared-components/selectorButton/style';and find some other way to achieve the same behavior.