Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pre-commit.ci] pre-commit autoupdate #1041

Closed
wants to merge 2 commits into from

Conversation

pre-commit-ci[bot]
Copy link
Contributor

@pre-commit-ci pre-commit-ci bot commented Oct 17, 2022

updates:
- [github.com/pre-commit/mirrors-prettier: v2.7.1 → v3.0.0-alpha.2](pre-commit/mirrors-prettier@v2.7.1...v3.0.0-alpha.2)
@pre-commit-ci pre-commit-ci bot requested a review from pokey as a code owner October 17, 2022 23:29
@auscompgeek
Copy link
Member

Most of this diff appears to be trailing commas defaulting to always. Should we add a prettier config to enable it on stable, then see what else changes afterwards?

@pokey
Copy link
Member

pokey commented Oct 20, 2022

I'd be happy to enable "all" for trailing commas, but I don't like the idea of being on an alpha autoformatter. I really wish pre-commit would respect semver. Really tempted to just write our own GitHub action to bump these respecting semver; shouldn't take more than an afternoon

@pokey
Copy link
Member

pokey commented Oct 24, 2022

Looks like this one has a million merge conflicts. Let's wait for the next pre-commit PR to come around and continue the discussion there? I'm not in love with being on an alpha version of an auto-formatter, no matter how much pre-commit wants us to be 😅

@pokey pokey closed this Oct 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants