implemented actions puff, float, drop #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pokey Could you try to push this one through? the latest changes in talon develop requires this one with the new action names for drink and pour. |
pokey
previously approved these changes
Jul 22, 2021
pokey
reviewed
Jul 22, 2021
| }); | ||
| } | ||
|
|
||
| const thatMark = targets.map((target) => { |
There was a problem hiding this comment.
So I guess it probably makes sense to have "that" refer to the targets as you've done here, tho it might be useful in the future to support something like a "changed" mark, because I could see wanting to refer to the newly insterted lines as well.
Also, this code can be removed once we have listenForDocumentChanges, right?
There was a problem hiding this comment.
My assumption was that if you wanted the new lines you would use drink and pour instead but I see your point.
Yes I believe so.
pokey
previously approved these changes
Jul 22, 2021
pokey
approved these changes
Jul 22, 2021
thetomcraig-aya
pushed a commit
to thetomcraig/cursorless
that referenced
this pull request
Mar 27, 2024
* Add black to CI * Apply black
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #68