Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added action replace #135

Merged
merged 22 commits into from
Jul 27, 2021
Merged

Added action replace #135

merged 22 commits into from
Jul 27, 2021

Conversation

AndreasArvidsson
Copy link
Member

@AndreasArvidsson AndreasArvidsson commented Jul 23, 2021 •
edited
Loading

  • Added action get text.
    • Used by homophones
    • Used by formatters
  • Added action replace.
    • Used to replace or insert text
    • Used by homophones
    • Used by formatters
    • Used by numeric ranges
  • Correctly distinguish between contents/after/end of
  • Major clean up. Start of unification.

This was linked to issues Jul 23, 2021
Add "phones" action #31
Closed
Support "reformat as" action #74
Closed
@AndreasArvidsson AndreasArvidsson marked this pull request as draft July 23, 2021 23:28
@AndreasArvidsson AndreasArvidsson linked an issue Jul 23, 2021 that may be closed by this pull request
Support "replace with" action #15
Closed
@AndreasArvidsson AndreasArvidsson linked an issue Jul 24, 2021 that may be closed by this pull request
Support numeric ranges for insert #48
Closed
@AndreasArvidsson AndreasArvidsson changed the base branch from master to develop July 24, 2021 21:48
@AndreasArvidsson AndreasArvidsson marked this pull request as ready for review July 25, 2021 00:10
@pokey pokey changed the base branch from develop to master July 25, 2021 01:01
pokey
pokey reviewed Jul 25, 2021
View reviewed changes
Copy link
Member

@pokey pokey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok got through most of this. there's really not a lot to take issue with it's a solid improvement. i haven't reviewed selectionUtils thoroughly yet. mixed feelings bout all the polymorphism there

but yeah let's try to get this one in today or tomorrow it looks great

src/actions/BringMoveSwap.ts Outdated Show resolved Hide resolved
src/actions/Find.ts Outdated Show resolved Hide resolved
src/actions/GetText.ts Show resolved Hide resolved
src/actions/GetText.ts Show resolved Hide resolved
src/Types.ts Outdated Show resolved Hide resolved
src/editStyles.ts Show resolved Hide resolved
src/getTextAdjustPosition.ts Outdated Show resolved Hide resolved
src/getTextAdjustPosition.ts Outdated Show resolved Hide resolved
src/getTextAdjustPosition.ts Outdated Show resolved Hide resolved
src/getTextAdjustPosition.ts Outdated Show resolved Hide resolved
@pokey pokey merged commit 9dcf9c0 into master Jul 27, 2021
@pokey pokey deleted the replace branch July 27, 2021 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pokey pokey pokey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@AndreasArvidsson @pokey