Added action remove selection #348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pokey
approved these changes
Dec 1, 2021
pokey
reviewed
Dec 1, 2021
| }); | ||
|
|
||
| return { | ||
| thatMark: targets.map((target) => target.selection), |
There was a problem hiding this comment.
Do you think the that mark would be more useful if it were the selections that got dropped? We could probably just leave it for now and see how it works in practice but just a thought
There was a problem hiding this comment.
I think we can leave it like this and try it out. In most cases that is token you actually referenced. But I do agree that could potentially be useful.
Maybe we can use the source mark?
There was a problem hiding this comment.
Hmm not sure source mark is right here but interesting idea. Agreed tho let's just see if we ever actually want a way to refer to the removed selections in practice
Co-authored-by: Pokey Rule <pokey.rule@gmail.com>
…into removeSelection
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #95