Implemented strict here selection type #352

AndreasArvidsson · 2021-12-02T12:44:18Z

Switch strict here to instead just have a field isImplicit, and no other fields than type
Switch "just" to use toRawTarget modifier
Run test upgrade for strict here
Upgrade "just" tests (don't need backward compatibility stuff because it's unreleased)
[WON'T DO] Add backwards compatibility test for strict here

pokey

Ok I'm happy with this one but @AndreasArvidsson this one is kinda my PR now so I think you're the one that should review it 😅

AndreasArvidsson requested a review from pokey as a code owner December 2, 2021 12:44

pokey marked this pull request as draft December 2, 2021 17:57

pokey added this to the 0.24.0 milestone Dec 7, 2021

pokey force-pushed the strictHere branch from 832171b to e9995ba Compare December 14, 2021 17:16

pokey self-assigned this Dec 15, 2021

AndreasArvidsson and others added 6 commits December 16, 2021 12:54

Implemented strict here selection type

af9dc3d

Initial backwards compatibility

e11be17

Start to refactor

1484c89

More changes

1db4216

Attempt to make new raw selections work

c89158c

Fix bug and add a bunch of tests

c47fa93

pokey force-pushed the strictHere branch from 3317f5e to c47fa93 Compare December 16, 2021 15:54

pokey mentioned this pull request Dec 16, 2021

Added strict here selection type cursorless-dev/cursorless-talon#114

Merged

Remove unused function

496e25c

pokey approved these changes Dec 16, 2021

View reviewed changes

pokey marked this pull request as ready for review December 16, 2021 16:04

AndreasArvidsson merged commit 57aeb8f into main Dec 16, 2021

AndreasArvidsson deleted the strictHere branch December 16, 2021 16:23

Provide feedback