Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed selection bug and added source mark to copy lines #384

Merged
merged 4 commits into from
Dec 12, 2021
Merged

Fixed selection bug and added source mark to copy lines #384

merged 4 commits into from
Dec 12, 2021

Conversation

AndreasArvidsson
Copy link
Member

  • Since is replaced was false empty selections at the end was incorrectly moved
  • Added source mark

pokey
pokey approved these changes Dec 12, 2021
View reviewed changes
Copy link
Member

@pokey pokey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good with some minor comments. Worth adding a test for "clone up" / "clone down" with cursor at start of line, because I believe there's a bug in "clone up" with cursor at start of line

src/actions/CopyLines.ts Outdated Show resolved Hide resolved
src/test/suite/fixtures/recorded/actions/clearSource.yml Outdated Show resolved Hide resolved
src/test/suite/fixtures/recorded/actions/clearSource2.yml Outdated Show resolved Hide resolved
src/test/suite/fixtures/recorded/actions/clearThat.yml Outdated Show resolved Hide resolved
src/test/suite/fixtures/recorded/actions/clearThat2.yml Outdated Show resolved Hide resolved
src/test/suite/fixtures/recorded/actions/cloneUpVest2.yml Outdated Show resolved Hide resolved
src/test/suite/fixtures/recorded/actions/cloneVest2.yml Outdated Show resolved Hide resolved
@AndreasArvidsson AndreasArvidsson added this to the 0.24.0 milestone Dec 12, 2021
@AndreasArvidsson AndreasArvidsson merged commit 9df55b6 into main Dec 12, 2021
@AndreasArvidsson AndreasArvidsson deleted the copyLines branch December 12, 2021 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pokey pokey pokey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.24.0
Development

Successfully merging this pull request may close these issues.
2 participants
@AndreasArvidsson @pokey