Adding Language Support for Go

[trace-andreason]

I haven't recorded any test cases yet, but everything seems to be working. The only thing that is missing is class and class name as go does not have classes.

[pokey]

Looks really good! Left a few comments. Let me know if you have any trouble with the test case recorder 😊

[pokey]

Wow 👏! Fantastic first PR 😄

There are a few more tests I'd love to see:

• "chuck arg" when there are two args in the arg list, to ensure that comma is properly cleaned up on removed arg
• "chuck arg" when there is one arg in the arg list, just to make sure delimiter code doesn't get tripped up
• "take every key" to ensure that sibling expansion works properly for keys
• "take every item" to ensure that sibling expansion works properly for items
• "take key" where the cursor is in the key itself
• "take value" where the cursor is in the value itself
• "take round" with a document like so: "(hello)", and cursor in the middle of hello. Will only work if you're on develop branch of cursorless-talon
• "clear if state"
• "clear condition"

Also, in other languages, we're able to say "take value" to select the value of a return statement. Would that be useful in Go in your opinion?

[pokey]

Another minor one for the future; not worth rewriting your tests, but we generally try to use "clear" for modifier tests so that the test case is easier to read; don't have to count character indices 😅. Not a big deal because in the future we'll have a better format for modifier tests that doesn't depend on which action you run

[pokey]

Also, would be great if you could file a PR against https://github.com/pokey/vscode-parse-tree for the parse tree support

[trace-andreason]

@pokey isn't go already in there?
https://github.com/pokey/vscode-parse-tree/blob/main/src/extension.ts#L20

[pokey]

@pokey isn't go already in there?

https://github.com/pokey/vscode-parse-tree/blob/main/src/extension.ts#L20

Ohhh ok. That's how you did it 😂. Forgot go was already supported by that extension

[trace-andreason]

@pokey ok, added almost all those tests. I didn't add these two:

"take round" with a document like so: "(hello)", and cursor in the middle of hello. Will only work if you're on develop branch of cursorless-talon
"clear condition"

Do I have to add the first? I based my branch on main.

For the second, I can't get the condition action to register in talon, I'm not sure why.

[pokey]

Looks like issue with resolving merge conflict

Suggested change

csharp: csharp,

[pokey]

@pokey ok, added almost all those tests. I didn't add these two:

"take round" with a document like so: "(hello)", and cursor in the middle of hello. Will only work if you're on develop branch of cursorless-talon "clear condition"

Do I have to add the first? I based my branch on main.

For the second, I can't get the condition action to register in talon, I'm not sure why.

no worries; I just added them myself. Thanks for all the great work! This should be released in the next couple days

[trace-andreason]

Thanks @pokey and @AndreasArvidsson! I'm planning to do rust next!

[AndreasArvidsson]

Good work! :)