Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to fold single line #394

Merged
merged 4 commits into from
Dec 17, 2021
Merged

Allow to fold single line #394

merged 4 commits into from
Dec 17, 2021

Conversation

AndreasArvidsson
Copy link
Member

@AndreasArvidsson AndreasArvidsson commented Dec 16, 2021

I could never figure out why none of the fold or unfold commands worked for me until I looked at the code. Apparently single line targets are filtered away. Why? The most obvious use case for fold is fold air and I can't see any reason why that shouldn't work.

Also made it so you can fold in a different editor/across splits

fixes #39

@pokey
Copy link
Member

pokey commented Dec 16, 2021

The problem is that if you say "fold every item", and one of the items is a single line, it will fold the whole map. Sorry I should have left a note in a comment

@pokey
Copy link
Member

pokey commented Dec 16, 2021

see #39

Copy link
Member

@pokey pokey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work!

@AndreasArvidsson AndreasArvidsson merged commit 8117983 into main Dec 17, 2021
@AndreasArvidsson AndreasArvidsson deleted the fold_single_line branch December 17, 2021 07:39
pokey added a commit that referenced this pull request Dec 17, 2021
pokey added a commit that referenced this pull request Dec 17, 2021
* Revert "Allow to fold single line (#394)"

This reverts commit 8117983.

* Keep good changes

* Keep good changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fold action not working properly with multiple list elements
2 participants