Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: missing opened metric on android 12 and above #43

Merged
merged 6 commits into from
Apr 26, 2023
Merged

fix: missing opened metric on android 12 and above #43

merged 6 commits into from
Apr 26, 2023

Conversation

Shahroz16
Copy link
Collaborator

@Shahroz16 Shahroz16 commented Apr 26, 2023 •
edited
Loading

@github-actions
Copy link

github-actions bot commented Apr 26, 2023 •
edited
Loading

Pull request title looks good 👍!

If this pull request gets merged, it will cause a new release of the software. Example: If this project's latest release version is 1.0.0. If this pull request gets merged in, the next release of this project will be 1.0.1. This pull request is not a breaking change.

All merged pull requests will eventually get deployed. But some types of pull requests will trigger a deployment (such as features and bug fixes) while some pull requests will wait to get deployed until a later time.

This project uses a special format for pull requests titles. Expand this section to learn more (expand by clicking the ᐅ symbol on the left side of this sentence)...

This project uses a special format for pull requests titles. Don't worry, it's easy!

This pull request title should be in this format:

<type>: short description of change being made

If your pull request introduces breaking changes to the code, use this format:

<type>!: short description of breaking change

where <type> is one of the following:

  • feat: - A feature is being added or modified by this pull request. Use this if you made any changes to any of the features of the project.

  • fix: - A bug is being fixed by this pull request. Use this if you made any fixes to bugs in the project.

  • docs: - This pull request is making documentation changes, only.

  • refactor: - A change was made that doesn't fix a bug or add a feature.

  • test: - Adds missing tests or fixes broken tests.

  • style: - Changes that do not effect the code (whitespace, linting, formatting, semi-colons, etc)

  • perf: - Changes improve performance of the code.

  • build: - Changes to the build system (maven, npm, gulp, etc)

  • ci: - Changes to the CI build system (Travis, GitHub Actions, Circle, etc)

  • chore: - Other changes to project that don't modify source code or test files.

  • revert: - Reverts a previous commit that was made.

Examples:

feat: edit profile photo
refactor!: remove deprecated v1 endpoints
build: update npm dependencies
style: run formatter

Need more examples? Want to learn more about this format? Check out the official docs.

Note: If your pull request does multiple things such as adding a feature and makes changes to the CI server and fixes some bugs then you might want to consider splitting this pull request up into multiple smaller pull requests.

@Shahroz16 Shahroz16 requested a review from a team April 26, 2023 12:58
mrehan27
mrehan27 approved these changes Apr 26, 2023
View reviewed changes
Copy link
Contributor

@mrehan27 mrehan27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just minor suggestions, rest looks good

android/build.gradle Outdated
@@ -58,7 +58,7 @@ android {
dependencies {
implementation "org.jetbrains.kotlin:kotlin-stdlib-jdk7:$kotlin_version"
// Customer.io SDK
def cioVersion = "[3.3,4.0)"
def cioVersion = "[3.4,4.0)"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is range, we can probably update the lowest version to current latest? 🤔

Suggested change
def cioVersion = "[3.4,4.0)"
def cioVersion = "[3.4.2,4.0)"

android/src/main/kotlin/io/customer/customer_io/CustomerIoPlugin.kt
@@ -214,7 +223,9 @@ class CustomerIoPlugin : FlutterPlugin, MethodCallHandler, ActivityAware {
Keys.Environment.ENABLE_IN_APP
)

CustomerIO.Builder(
val isLifecycleCallbacksRegistered = kotlin.runCatching { CustomerIO.instance() }.isSuccess
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A small comment to this variable would be helpful

@Shahroz16 Shahroz16 merged commit 1a61e0e into main Apr 26, 2023
@Shahroz16 Shahroz16 deleted the shahroz/opened-metric-android-12 branch April 26, 2023 20:39
github-actions bot pushed a commit that referenced this pull request Apr 26, 2023
@semantic-release-bot
chore: prepare for 1.1.1
ca30093 
### [1.1.1](1.1.0...1.1.1) (2023-04-26)

### Bug Fixes

* missing opened metric on android 12 and above ([#43](#43)) ([1a61e0e](1a61e0e))
github-actions bot pushed a commit to nagyist/customerio-flutter that referenced this pull request Oct 18, 2023
@semantic-release-bot
chore: prepare for 1.0.0
52d4431 
## 1.0.0 (2023-10-18)

### Features

* added missing methods ([customerio#17](https://github.com/nagyist/customerio-flutter/issues/17)) ([73f29e6](73f29e6))
* added SDK config  ([#1](#1)) ([e8ed7dd](e8ed7dd))
* in-app dismiss support ([customerio#51](https://github.com/nagyist/customerio-flutter/issues/51)) ([c4d21f2](c4d21f2))
* process push notifications received outside CIO SDK ([customerio#38](https://github.com/nagyist/customerio-flutter/issues/38)) ([7b5cb7e](7b5cb7e))
* tracking and in-app added ([#2](#2)) ([c23f2d9](c23f2d9))

### Bug Fixes

* add test coverage and refactored scripts ([customerio#34](https://github.com/nagyist/customerio-flutter/issues/34)) ([f7f2387](f7f2387))
* autoupdate to latest major version of iOS SDK ([customerio#40](https://github.com/nagyist/customerio-flutter/issues/40)) ([974a342](974a342))
* formatting issues ([d67fa7e](d67fa7e))
* hardcode android native SDK version ([customerio#61](https://github.com/nagyist/customerio-flutter/issues/61)) ([587f559](587f559))
* in-app concurrency issue android ([customerio#73](https://github.com/nagyist/customerio-flutter/issues/73)) ([93332a4](93332a4))
* in-app crash for no browser ([customerio#94](https://github.com/nagyist/customerio-flutter/issues/94)) ([8b859ed](8b859ed))
* in-app messages not displaying for release builds on Android ([customerio#65](https://github.com/nagyist/customerio-flutter/issues/65)) ([1d742c2](1d742c2))
* in-app remove gist org id ([customerio#19](https://github.com/nagyist/customerio-flutter/issues/19)) ([ce4cc9e](ce4cc9e))
* iOS crash on forced unwrapping  ([customerio#59](https://github.com/nagyist/customerio-flutter/issues/59)) ([f514174](f514174))
* missing methods and extra dependency ([2c5deca](2c5deca))
* missing opened metric on android 12 and above ([customerio#43](https://github.com/nagyist/customerio-flutter/issues/43)) ([1a61e0e](1a61e0e))
* obj-c bindings issue ([0dbe4ef](0dbe4ef))
* plugin version in user-agent ([a10e482](a10e482))
* release script typo ([2a8b7ae](2a8b7ae))
* stack-overflow caused by BQ recursion ([customerio#90](https://github.com/nagyist/customerio-flutter/issues/90)) ([ebc7511](ebc7511))
* typo fixed ([customerio#9](https://github.com/nagyist/customerio-flutter/issues/9)) ([a5107df](a5107df)), closes [#7](#7) [#8](#8)
* updated android dependency to auto update ([customerio#24](https://github.com/nagyist/customerio-flutter/issues/24)) ([040cef2](040cef2))
* updated icon and typo ([57c6eef](57c6eef))
* updated module name from common to CioInternalCommon ([customerio#55](https://github.com/nagyist/customerio-flutter/issues/55)) ([d81f8df](d81f8df))
github-actions bot pushed a commit to AristideVB/customerio-flutter that referenced this pull request Oct 12, 2024
@semantic-release-bot
chore: prepare for 1.0.0
acc5dad 
## 1.0.0 (2024-10-12)

### Features

* added missing methods ([customerio#17](https://github.com/AristideVB/customerio-flutter/issues/17)) ([73f29e6](73f29e6))
* added SDK config  ([customerio#1](https://github.com/AristideVB/customerio-flutter/issues/1)) ([e8ed7dd](e8ed7dd))
* do not show modal message if screen changes and page rule mismatches ([customerio#131](https://github.com/AristideVB/customerio-flutter/issues/131)) ([a563055](a563055))
* in-app dismiss support ([customerio#51](https://github.com/AristideVB/customerio-flutter/issues/51)) ([c4d21f2](c4d21f2))
* in-app message persistence ([customerio#97](https://github.com/AristideVB/customerio-flutter/issues/97)) ([71d85cc](71d85cc))
* process push notifications received outside CIO SDK ([customerio#38](https://github.com/AristideVB/customerio-flutter/issues/38)) ([7b5cb7e](7b5cb7e))
* support for android gradle plugin 8 ([customerio#117](https://github.com/AristideVB/customerio-flutter/issues/117)) ([48b4e06](48b4e06))
* tracking and in-app added ([customerio#2](https://github.com/AristideVB/customerio-flutter/issues/2)) ([c23f2d9](c23f2d9))

### Bug Fixes

* add test coverage and refactored scripts ([customerio#34](https://github.com/AristideVB/customerio-flutter/issues/34)) ([f7f2387](f7f2387))
* added proguard rules for R8 strict mode ([customerio#116](https://github.com/AristideVB/customerio-flutter/issues/116)) ([9946fe7](9946fe7))
* autoupdate to latest major version of iOS SDK ([customerio#40](https://github.com/AristideVB/customerio-flutter/issues/40)) ([974a342](974a342))
* formatting issues ([d67fa7e](d67fa7e))
* hardcode android native SDK version ([customerio#61](https://github.com/AristideVB/customerio-flutter/issues/61)) ([587f559](587f559))
* improve android push click behavior ([customerio#89](https://github.com/AristideVB/customerio-flutter/issues/89)) ([62b9e61](62b9e61))
* improve in-app logs ([customerio#139](https://github.com/AristideVB/customerio-flutter/issues/139)) ([b10cc75](b10cc75))
* in-app concurrency issue android ([customerio#73](https://github.com/AristideVB/customerio-flutter/issues/73)) ([93332a4](93332a4))
* in-app crash for no browser ([customerio#94](https://github.com/AristideVB/customerio-flutter/issues/94)) ([8b859ed](8b859ed))
* in-app messages not displaying for release builds on Android ([customerio#65](https://github.com/AristideVB/customerio-flutter/issues/65)) ([1d742c2](1d742c2))
* in-app remove gist org id ([customerio#19](https://github.com/AristideVB/customerio-flutter/issues/19)) ([ce4cc9e](ce4cc9e))
* iOS crash on forced unwrapping  ([customerio#59](https://github.com/AristideVB/customerio-flutter/issues/59)) ([f514174](f514174))
* missing methods and extra dependency ([2c5deca](2c5deca))
* missing opened metric on android 12 and above ([customerio#43](https://github.com/AristideVB/customerio-flutter/issues/43)) ([1a61e0e](1a61e0e))
* obj-c bindings issue ([0dbe4ef](0dbe4ef))
* plugin version in user-agent ([a10e482](a10e482))
* release script typo ([2a8b7ae](2a8b7ae))
* send native to flutter messages on main thread ([customerio#134](https://github.com/AristideVB/customerio-flutter/issues/134)) ([bc8704b](bc8704b))
* stack-overflow caused by BQ recursion ([customerio#90](https://github.com/AristideVB/customerio-flutter/issues/90)) ([ebc7511](ebc7511))
* typo fixed ([customerio#9](https://github.com/AristideVB/customerio-flutter/issues/9)) ([a5107df](a5107df)), closes [customerio#7](https://github.com/AristideVB/customerio-flutter/issues/7) [customerio#8](https://github.com/AristideVB/customerio-flutter/issues/8)
* updated android dependency to auto update ([customerio#24](https://github.com/AristideVB/customerio-flutter/issues/24)) ([040cef2](040cef2))
* updated icon and typo ([57c6eef](57c6eef))
* updated module name from common to CioInternalCommon ([customerio#55](https://github.com/AristideVB/customerio-flutter/issues/55)) ([d81f8df](d81f8df))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrehan27 mrehan27 mrehan27 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Shahroz16 @mrehan27