-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: build sample apps #298
Conversation
c78be01
to
d0c027a
Compare
c5fda9a
to
c0e6c78
Compare
253db05
to
35c79f1
Compare
c0e6c78
to
64e110e
Compare
9bc4a2d
to
29adc48
Compare
Sample app builds 📱Below you will find the list of the latest versions of the sample apps. It's recommended to always download the latest builds of the sample apps to accurately test the pull request.
|
95898bd
to
300f384
Compare
8f8acba
to
4949d99
Compare
21da139
to
0e0b04f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Non-blocking comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, just suggestions and minor impvorments
- name: Find Comment | ||
uses: peter-evans/find-comment@v3 | ||
id: existing-comment | ||
with: | ||
issue-number: ${{ github.event.pull_request.number }} | ||
comment-author: "github-actions[bot]" | ||
body-includes: <!-- sample app builds --> | ||
|
||
- name: Create or update comment | ||
uses: peter-evans/create-or-update-comment@v4 | ||
id: create-comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Find Comment" and "Create or update comment" can be combined into a single step ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking at other repos and docs, looks like it needs two steps.
part of MBL-421
Changes