Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: build sample apps #298

Merged
merged 8 commits into from
Aug 19, 2024
Merged

ci: build sample apps #298

merged 8 commits into from
Aug 19, 2024

Conversation

mrehan27
Copy link
Contributor

part of MBL-421

Changes

  • Updated github actions to build sample apps for every pull request created

@mrehan27 mrehan27 self-assigned this Aug 14, 2024
@mrehan27 mrehan27 force-pushed the rehan/mbl-421-fastlane-updates branch from c78be01 to d0c027a Compare August 15, 2024 13:00
@mrehan27 mrehan27 force-pushed the rehan/mbl-421-fastlane-updates branch 2 times, most recently from 253db05 to 35c79f1 Compare August 15, 2024 20:30
@mrehan27 mrehan27 changed the base branch from rehan/mbl-421-fastlane-updates to rehan/mbl-421-apn-fixes August 15, 2024 20:46
@mrehan27 mrehan27 marked this pull request as ready for review August 16, 2024 06:43
@mrehan27 mrehan27 force-pushed the rehan/mbl-421-ci-updates branch 2 times, most recently from 9bc4a2d to 29adc48 Compare August 16, 2024 07:26
Copy link

github-actions bot commented Aug 16, 2024

Sample app builds 📱

Below you will find the list of the latest versions of the sample apps. It's recommended to always download the latest builds of the sample apps to accurately test the pull request.


  • FCM: 298.8.0 (28734918)
  • APN: 298.8.0 (28734918)

@mrehan27 mrehan27 force-pushed the rehan/mbl-421-ci-updates branch 2 times, most recently from 95898bd to 300f384 Compare August 16, 2024 09:53
@mrehan27 mrehan27 requested a review from a team August 16, 2024 10:20
Copy link
Collaborator

@ami-aman ami-aman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Non-blocking comment

Copy link
Contributor

@Shahroz16 Shahroz16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, just suggestions and minor impvorments

.github/workflows/build-sample-apps.yml Outdated Show resolved Hide resolved
Comment on lines +26 to +36
- name: Find Comment
uses: peter-evans/find-comment@v3
id: existing-comment
with:
issue-number: ${{ github.event.pull_request.number }}
comment-author: "github-actions[bot]"
body-includes: <!-- sample app builds -->

- name: Create or update comment
uses: peter-evans/create-or-update-comment@v4
id: create-comment
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Find Comment" and "Create or update comment" can be combined into a single step ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at other repos and docs, looks like it needs two steps.

Base automatically changed from rehan/mbl-421-apn-fixes to main August 19, 2024 19:13
@mrehan27 mrehan27 merged commit 2e3f46b into main Aug 19, 2024
9 checks passed
@mrehan27 mrehan27 deleted the rehan/mbl-421-ci-updates branch August 19, 2024 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants