chore: update native module to initialize & configure SDK using Datapipeline (iOS) #299
Conversation
| import React | ||
|
|
||
| func flush() { | ||
| #if DEBUG |
There was a problem hiding this comment.
Why the debug flag is added here? Do we intend to not perform any action on production for this method?
There was a problem hiding this comment.
yes, this is intended to be called only in debug/development build to help testing.
| @objc | ||
| func clearIdentify() { | ||
| CustomerIO.shared.clearIdentify() | ||
| flush() |
There was a problem hiding this comment.
Why are we flushing after every call?
There was a problem hiding this comment.
This is meant to facilitate testing on sample apps. Not a requirement though, but rather a method to help test the package more efficiently and quickly.
| } | ||
| } | ||
|
|
||
| struct CioConfig { |
There was a problem hiding this comment.
Will this be exposed to public? If yes, I would suggest to use full name instead i.e. CustomerIOConfig
There was a problem hiding this comment.
yes, this will be exposed to public. This is same as CustomerIOConfig as we have today, just a rename and has been called out in the tech proposal as well.
I’m okay with renaming it back to CustomerIOConfig if there’s a strong reason to do so!
For me, CioConfig is short and precisely describes the context such as within a module or codebase whenever we use “CIO” it is commonly understood to refer to Customer.io.
Linear ticket : https://linear.app/customerio/issue/MBL-446/[ios]-update-native-module-to-initialize-and-configure-sdk-using
Problem
As a developer, I want to be able to consume
customerio-reactnativepackage in my application without any error. I want to update the native module to initialize and configure the SDK using Datapipeline so that I can ensure seamless integration and configuration of the SDK with the latest data pipeline functionalities using iOS SDK.Solution
CioDataPipelineand removeCioTrackingmodulecustomerio-reactnative.podspecnow usesCioDataPipelineand no longer usesCioTrackingNative module code has been updated to use CioDataPipeline and removes
CioTrackingwhere ever usedWith data ppiline module, updated configurations have been used
Removed the old tracking module references and any associated code that is no longer necessary with the use of the DataPipeline module.
package.jsonTo help the customer use specific & strict iOS SDK version, we use
cioNativeiOSSdkVersionattribute in package'spackage.jsonfile. This has been updated to use latest iOS SDK version i.e.3.3.3providing CDP support.Todo(s) have been added to respective files wherever necessary, to be removed later when respective features are implemented
Sample app has been updated (FCM for now, as APN is failing to build for all devs. Need to fix this in another PR)
Testing and Validation
Completed development testing with no additional test steps required, as this update is focused solely on the initialization of the SDK. Added identify code to further test the feature, confirming that it works as expected.
Steps:
Test user created - https://fly.customer.io/workspaces/122175/journeys/people/bfba070080048104