Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add latest configurations to settings screen for fcm sample app #303

Merged
merged 25 commits into from
Aug 19, 2024

Conversation

ami-aman
Copy link
Collaborator

Linear ticket : https://linear.app/customerio/issue/MBL-445/update-setting-screen-to-use-latest-configurations

Problem/Context

This PR implements the latest configurations in the FCM sample app. Sample app users can now modify settings such as cdpApiKey and track lifecycle events directly from the settings screen. (APN sample app changes are yet to be done)

Solution/Changes

  • New configurations added : cdpApiKey, app lifecycle event tracking
  • Outdated configurations removed : trackingApiUrl, background queue configurations
  • UI has been made similar to what Scott's loom suggested.
  • Though out of scope but to save time & efforts later I have added configurations such as CDN Host, API Host, Flush At and Flush interval with a save button. There is no action on save button yet, will create another ticket for this acceptance criteria.
  • The device token isn’t displayed yet because the feature hasn’t been added to the package, and in the sample app, it has been commented out to avoid unnecessary app crashes.

Testing

FCM.sample.app.mp4

@ami-aman ami-aman requested a review from a team August 16, 2024 14:49
Copy link
Contributor

@mrehan27 mrehan27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small comments, looks good overall 👍🏻

Apps/FCM/src/screens/InternalSettings.tsx Outdated Show resolved Hide resolved
Apps/FCM/src/screens/InternalSettings.tsx Outdated Show resolved Hide resolved
@ami-aman ami-aman merged commit f96b610 into feature/cdp-milestone-one Aug 19, 2024
1 of 5 checks passed
@ami-aman ami-aman deleted the feature/cdp/setting-screen-update branch August 19, 2024 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants