Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This gem only depends on ActionPack and Railties, not all of Rails. The downside of having Rails as a dependency means all apps using this gem will be required to install ActiveRecord, ActionText, ActiveStorage, etc.
Why is this important?
This means that any app or library using actionpack-cloudfront at the moment must also be GPL-2.0. Although this issue is currently being addressed by Rails and MimeMagic, apps trying to get around this issue by excluding ActiveStorage cannot due to the explicit dependency declared here.