Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Declare more specific dependencies #12

Merged
merged 1 commit into from
Mar 29, 2021

Conversation

tonyta
Copy link
Contributor

@tonyta tonyta commented Mar 24, 2021

Description

This gem only depends on ActionPack and Railties, not all of Rails. The downside of having Rails as a dependency means all apps using this gem will be required to install ActiveRecord, ActionText, ActiveStorage, etc.

Why is this important?

This means that any app or library using actionpack-cloudfront at the moment must also be GPL-2.0. Although this issue is currently being addressed by Rails and MimeMagic, apps trying to get around this issue by excluding ActiveStorage cannot due to the explicit dependency declared here.

rails_version = "6.1.3"
# gem "rails",         rails_version
gem "activesupport", rails_version
gem "actionpack",    rails_version
gem "actionview",    rails_version
gem "activemodel",   rails_version
gem "activerecord",  rails_version
gem "actionmailer",  rails_version
gem "activejob",     rails_version
gem "actioncable",   rails_version
# gem "activestorage", rails_version # ❌ Still pulled in by actionpack-cloudfront
gem "actionmailbox", rails_version
gem "actiontext",    rails_version
gem "railties",      rails_version

gem "bundler",         ">= 1.15.0"
gem "sprockets-rails", ">= 2.0.0"

This gem only depends on ActionPack and Railties, not all of Rails. The
downside of having Rails as a dependency means all apps using this gem
will be required to install ActiveRecord, ActionText, ActiveStorage,
etc.
@metaskills
Copy link
Contributor

Thanks! I do not see an issue with this. Seems we are past the mimemagic issue now too.

@metaskills metaskills merged commit b7f75a6 into customink:master Mar 29, 2021
@metaskills
Copy link
Contributor

v1.1.0 pushed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants