Skip to content

Commit

Permalink
Fixed issue: autoborder points are visible for invisible shapes (#3931)
Browse files Browse the repository at this point in the history
* Fixed issue: autoborder points are visible for invisible shapes

* Update version & changelog
  • Loading branch information
Boris Sekachev committed Nov 24, 2021
1 parent 1f33f50 commit c787f04
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 4 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

### Fixed
- Fixed Interaction handler keyboard handlers (<https://github.com/openvinotoolkit/cvat/pull/3881>)
- Points of invisible shapes are visible in autobordering (<https://github.com/openvinotoolkit/cvat/pull/3931>)

### Security
- TDB
Expand Down
4 changes: 2 additions & 2 deletions cvat-canvas/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion cvat-canvas/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "cvat-canvas",
"version": "2.9.0",
"version": "2.9.1",
"description": "Part of Computer Vision Annotation Tool which presents its canvas library",
"main": "src/canvas.ts",
"scripts": {
Expand Down
3 changes: 2 additions & 1 deletion cvat-canvas/src/typescript/autoborderHandler.ts
Original file line number Diff line number Diff line change
Expand Up @@ -237,7 +237,8 @@ export class AutoborderHandlerImpl implements AutoborderHandler {

const currentClientID = this.currentShape.node.dataset.originClientId;
const shapes = Array.from(this.frameContent.getElementsByClassName('cvat_canvas_shape')).filter(
(shape: HTMLElement): boolean => +shape.getAttribute('clientID') !== this.currentID,
(shape: HTMLElement): boolean => +shape.getAttribute('clientID') !== this.currentID &&
!shape.classList.contains('cvat_canvas_hidden'),
);
const transformedShapes = shapes
.map((shape: HTMLElement): TransformedShape | null => {
Expand Down

0 comments on commit c787f04

Please sign in to comment.