Can't disable traefik ingress controller without removing ingress object #5733
Labels
enhancement
New feature or request
Comments
|
Could you prepare a PR? |
7 tasks
bsekachev
pushed a commit
that referenced
this issue
Jul 25, 2023
<!-- Raise an issue to propose your change (https://github.com/opencv/cvat/issues). It helps to avoid duplication of efforts from multiple independent contributors. Discuss your ideas with maintainers to be sure that changes will be approved and merged. Read the [Contribution guide](https://opencv.github.io/cvat/docs/contributing/). --> <!-- Provide a general summary of your changes in the Title above --> ### Motivation and context <!-- Why is this change required? What problem does it solve? If it fixes an open issue, please link to the issue here. Describe your changes in detail, add screenshots. --> Right now helm chart is broken and not usable at least in my environment, I trying to fix it to make it work content: 1. Moved test-related values to another values.file to separate it from default config 2. fixed issue with multiple caches in same RWX volume, which prevents db migration to start 3. Removed hardcoded mandatory traefik ingress usage 4. Added confugurable default storage option to chart ### How has this been tested? <!-- Please describe in detail how you tested your changes. Include details of your testing environment, and the tests you ran to see how your change affects other areas of the code, etc. --> We test it on our AKS with RWX volume ### Checklist <!-- Go over all the following points, and put an `x` in all the boxes that apply. If an item isn't applicable for some reason, then ~~explicitly strikethrough~~ the whole line. If you don't do that, GitHub will show incorrect progress for the pull request. If you're unsure about any of these, don't hesitate to ask. We're here to help! --> - [x] I submit my changes into the `develop` branch - [x] I have added a description of my changes into the [CHANGELOG](https://github.com/opencv/cvat/blob/develop/CHANGELOG.md) file - [x] I have updated the documentation accordingly - [x] I have added tests to cover my changes - [x] I have linked related issues (see [GitHub docs]( https://help.github.com/en/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword)) - [x] I have increased versions of npm packages if it is necessary ([cvat-canvas](https://github.com/opencv/cvat/tree/develop/cvat-canvas#versioning), [cvat-core](https://github.com/opencv/cvat/tree/develop/cvat-core#versioning), [cvat-data](https://github.com/opencv/cvat/tree/develop/cvat-data#versioning) and [cvat-ui](https://github.com/opencv/cvat/tree/develop/cvat-ui#versioning)) ### License - [x] I submit _my code changes_ under the same [MIT License]( https://github.com/opencv/cvat/blob/develop/LICENSE) that covers the project. Feel free to contact the maintainers if that's a concern. closes #6043 closes #6096 closes #5733 --------- Co-authored-by: Michael Kirpichev <m.kirpichev@haut.ai> Co-authored-by: Nikita Manovich <nikita@cvat.ai> Co-authored-by: Andrey Zhavoronkov <andrey@cvat.ai>
mikhail-treskin
pushed a commit
to retailnext/cvat
that referenced
this issue
Oct 25, 2023
<!-- Raise an issue to propose your change (https://github.com/opencv/cvat/issues). It helps to avoid duplication of efforts from multiple independent contributors. Discuss your ideas with maintainers to be sure that changes will be approved and merged. Read the [Contribution guide](https://opencv.github.io/cvat/docs/contributing/). --> <!-- Provide a general summary of your changes in the Title above --> ### Motivation and context <!-- Why is this change required? What problem does it solve? If it fixes an open issue, please link to the issue here. Describe your changes in detail, add screenshots. --> Right now helm chart is broken and not usable at least in my environment, I trying to fix it to make it work content: 1. Moved test-related values to another values.file to separate it from default config 2. fixed issue with multiple caches in same RWX volume, which prevents db migration to start 3. Removed hardcoded mandatory traefik ingress usage 4. Added confugurable default storage option to chart ### How has this been tested? <!-- Please describe in detail how you tested your changes. Include details of your testing environment, and the tests you ran to see how your change affects other areas of the code, etc. --> We test it on our AKS with RWX volume ### Checklist <!-- Go over all the following points, and put an `x` in all the boxes that apply. If an item isn't applicable for some reason, then ~~explicitly strikethrough~~ the whole line. If you don't do that, GitHub will show incorrect progress for the pull request. If you're unsure about any of these, don't hesitate to ask. We're here to help! --> - [x] I submit my changes into the `develop` branch - [x] I have added a description of my changes into the [CHANGELOG](https://github.com/opencv/cvat/blob/develop/CHANGELOG.md) file - [x] I have updated the documentation accordingly - [x] I have added tests to cover my changes - [x] I have linked related issues (see [GitHub docs]( https://help.github.com/en/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword)) - [x] I have increased versions of npm packages if it is necessary ([cvat-canvas](https://github.com/opencv/cvat/tree/develop/cvat-canvas#versioning), [cvat-core](https://github.com/opencv/cvat/tree/develop/cvat-core#versioning), [cvat-data](https://github.com/opencv/cvat/tree/develop/cvat-data#versioning) and [cvat-ui](https://github.com/opencv/cvat/tree/develop/cvat-ui#versioning)) ### License - [x] I submit _my code changes_ under the same [MIT License]( https://github.com/opencv/cvat/blob/develop/LICENSE) that covers the project. Feel free to contact the maintainers if that's a concern. closes cvat-ai#6043 closes cvat-ai#6096 closes cvat-ai#5733 --------- Co-authored-by: Michael Kirpichev <m.kirpichev@haut.ai> Co-authored-by: Nikita Manovich <nikita@cvat.ai> Co-authored-by: Andrey Zhavoronkov <andrey@cvat.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hi!
We have the next use case: we are using k8s with already installed nginx ingress controller. In fact it can be any ingress controller of our choice. As well - it may be already installed traefik. Right now I can't disable installation of traefik embedded into CVAT helm chart because in that case Ingress object won't be created.
https://github.com/opencv/cvat/blob/27224f25967d5e13ade686c4dc7f1bd363415d74/helm-chart/Chart.yaml#L61
https://github.com/opencv/cvat/blob/27224f25967d5e13ade686c4dc7f1bd363415d74/helm-chart/values.yaml#L289
The expected behaviour:
to have two options in helm chart:
My proposal is to make another enabled option under traefik block in values.yaml:
and to change traefik block in Chart.yaml:
The change is trivial, so I may create a PR for it.
The text was updated successfully, but these errors were encountered: