Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot save annotation #5966

Closed
2 tasks done
Legend94rz opened this issue Apr 4, 2023 · 5 comments · Fixed by #5968
Closed
2 tasks done

Cannot save annotation #5966

Legend94rz opened this issue Apr 4, 2023 · 5 comments · Fixed by #5968
Labels
bug Something isn't working

Comments

@Legend94rz
Copy link

Legend94rz commented Apr 4, 2023

My actions before raising this issue

Steps to Reproduce (for bugs)

I have a tracking job, which has only 1 class and the box has 2 mutable attributes.
It seems like the problem occurs when clicking the attribute ratio button.

All the 2 attributes and bounding box has nothing to do with rotation, which reported by the cvat error (see below).
I cannot provide a 100% reproducible steps, because this problem happened by accident, I was not able to fully reconstruct the operation that will trigger this problem.

Expected Behaviour

save the annotation without error.

Current Behaviour

image
when save annotation, it shows:
image
and sometimes show:
image

here is the browser's console output:

Failed to load resource: the server responded with a status of 400 (Bad Request)
cvat-app.tsx:353 Error: Request failed with status code 400. {"tracks":[{"shapes":[{},{},{},{},{},{},{},{},{},{},{},{},{},{},{},{},{},{},{},{},{},{},{},{},{},{},{},{},{},{},{},{},{},{},{},{},{},{},{},{},{},{},{},{},{},{"rotation":["This field may not be null."]},{"rotation":["This field may not be null."]},{"rotation":["This field may not be null."]},{}]}]}.
e @ cvat-app.tsx:353

Possible Solution

Context

Your Environment

  • Git hash commit (git log -1): commit 61470b621e0786a7977dbc131a84550a49524382 (HEAD -> 2.4.0, tag: v2.4.0, origin/master)
  • Docker version docker version (e.g. Docker 17.0.05):
Client: Docker Engine - Community
 Version:           23.0.1
 API version:       1.42
 Go version:        go1.19.5
 Git commit:        a5ee5b1
 Built:             Thu Feb  9 19:46:49 2023
 OS/Arch:           linux/amd64
 Context:           default

Server: Docker Engine - Community
 Engine:
  Version:          23.0.1
  API version:      1.42 (minimum version 1.12)
  Go version:       go1.19.5
  Git commit:       bc3805a
  Built:            Thu Feb  9 19:46:49 2023
  OS/Arch:          linux/amd64
  Experimental:     false
 containerd:
  Version:          1.6.18
  GitCommit:        2456e983eb9e37e47538f59ea18f2043c9a73640
 runc:
  Version:          1.1.4
  GitCommit:        v1.1.4-0-g5fd4c4d
 docker-init:
  Version:          0.19.0
  GitCommit:        de40ad0
  • Are you using Docker Swarm or Kubernetes? no
  • Operating System and version (e.g. Linux, Windows, MacOS): ubuntu 18.04
  • Code example or link to GitHub repo or gist to reproduce problem: no
  • Other diagnostic information / logs:
    Logs from `cvat` container
@bsekachev
Copy link
Member

@Legend94rz

Thank you for the report. I was able to reproduce the issue.

@bsekachev bsekachev added the bug Something isn't working label Apr 4, 2023
@bsekachev
Copy link
Member

@Legend94rz

Could you try the fix above? If it works, I will add a test and merge it.

@Legend94rz
Copy link
Author

Legend94rz commented Apr 4, 2023

@bsekachev really thanks for your so quick reply, I'll test it.

bsekachev added a commit that referenced this issue Apr 5, 2023
<!-- Raise an issue to propose your change
(https://github.com/opencv/cvat/issues).
It helps to avoid duplication of efforts from multiple independent
contributors.
Discuss your ideas with maintainers to be sure that changes will be
approved and merged.
Read the [Contribution
guide](https://opencv.github.io/cvat/docs/contributing/). -->

<!-- Provide a general summary of your changes in the Title above -->

### Motivation and context
Resolved #5966 

### How has this been tested?
<!-- Please describe in detail how you tested your changes.
Include details of your testing environment, and the tests you ran to
see how your change affects other areas of the code, etc. -->

### Checklist
<!-- Go over all the following points, and put an `x` in all the boxes
that apply.
If an item isn't applicable for some reason, then ~~explicitly
strikethrough~~ the whole
line. If you don't do that, GitHub will show incorrect progress for the
pull request.
If you're unsure about any of these, don't hesitate to ask. We're here
to help! -->
- [x] I submit my changes into the `develop` branch
- [x] I have added a description of my changes into the
[CHANGELOG](https://github.com/opencv/cvat/blob/develop/CHANGELOG.md)
file
- [ ] I have updated the documentation accordingly
- [x] I have added tests to cover my changes
- [x] I have linked related issues (see [GitHub docs](

https://help.github.com/en/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword))
- [x] I have increased versions of npm packages if it is necessary

([cvat-canvas](https://github.com/opencv/cvat/tree/develop/cvat-canvas#versioning),

[cvat-core](https://github.com/opencv/cvat/tree/develop/cvat-core#versioning),

[cvat-data](https://github.com/opencv/cvat/tree/develop/cvat-data#versioning)
and

[cvat-ui](https://github.com/opencv/cvat/tree/develop/cvat-ui#versioning))

### License

- [x] I submit _my code changes_ under the same [MIT License](
https://github.com/opencv/cvat/blob/develop/LICENSE) that covers the
project.
  Feel free to contact the maintainers if that's a concern.

---------

Co-authored-by: Nikita Manovich <nikita@cvat.ai>
@Legend94rz
Copy link
Author

@bsekachev Sorry for the late reponse.
Unfortunately, this problem still exists.
I update the cvat repo to commit 6e75fb27ad3d2f91cc730b34d8c713c963c99fb1 (HEAD -> bs/fixed_issue_5966, origin/bs/fixed_issue_5966) and the start cmd of docker compose is docker compose -f docker-compose.yml -f docker-compose.override.yml up -d.

The job that I test is created before this fix. Is it related? After serveral annotation steps, and it report error when saving. really annoying, I have to go back to the main page of cvat without saving my job and then re-annotate.

The error is same as above:
Error: Request failed with status code 400. {"tracks":[{"shapes":[{},{},{},{},{},{},{},{},{},{},{},{},{},{},{},{},{},{},{},{},{},{},{},{},{},{},{},{},{},{},{},{},{},{},{},{},{},{},{},{},{},{},{},{},{},{"rotation":["This field may not be null."]},{"rotation":["This field may not be null."]},{"rotation":["This field may not be null."]},{}]}]}.

@bsekachev
Copy link
Member

bsekachev commented Apr 7, 2023

docker compose -f docker-compose.yml -f docker-compose.override.yml up -d. is not enough.
This way you only run containers, but changing source code requires rebuilding the images.

Try this:
docker compose -f docker-compose.yml -f docker-compse.dev.yml -f docker-compose.override.yml up -d --build

mikhail-treskin pushed a commit to retailnext/cvat that referenced this issue Jul 1, 2023
)

<!-- Raise an issue to propose your change
(https://github.com/opencv/cvat/issues).
It helps to avoid duplication of efforts from multiple independent
contributors.
Discuss your ideas with maintainers to be sure that changes will be
approved and merged.
Read the [Contribution
guide](https://opencv.github.io/cvat/docs/contributing/). -->

<!-- Provide a general summary of your changes in the Title above -->

### Motivation and context
Resolved cvat-ai#5966 

### How has this been tested?
<!-- Please describe in detail how you tested your changes.
Include details of your testing environment, and the tests you ran to
see how your change affects other areas of the code, etc. -->

### Checklist
<!-- Go over all the following points, and put an `x` in all the boxes
that apply.
If an item isn't applicable for some reason, then ~~explicitly
strikethrough~~ the whole
line. If you don't do that, GitHub will show incorrect progress for the
pull request.
If you're unsure about any of these, don't hesitate to ask. We're here
to help! -->
- [x] I submit my changes into the `develop` branch
- [x] I have added a description of my changes into the
[CHANGELOG](https://github.com/opencv/cvat/blob/develop/CHANGELOG.md)
file
- [ ] I have updated the documentation accordingly
- [x] I have added tests to cover my changes
- [x] I have linked related issues (see [GitHub docs](

https://help.github.com/en/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword))
- [x] I have increased versions of npm packages if it is necessary

([cvat-canvas](https://github.com/opencv/cvat/tree/develop/cvat-canvas#versioning),

[cvat-core](https://github.com/opencv/cvat/tree/develop/cvat-core#versioning),

[cvat-data](https://github.com/opencv/cvat/tree/develop/cvat-data#versioning)
and

[cvat-ui](https://github.com/opencv/cvat/tree/develop/cvat-ui#versioning))

### License

- [x] I submit _my code changes_ under the same [MIT License](
https://github.com/opencv/cvat/blob/develop/LICENSE) that covers the
project.
  Feel free to contact the maintainers if that's a concern.

---------

Co-authored-by: Nikita Manovich <nikita@cvat.ai>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants