CVAT UI: batch of fixes #1705

ActiveChooN · 2020-06-14T22:29:02Z

Motivation and context

This PR resolve several issues and fix some of eslint problems.

Resolve #918
Resolve #1458
Resolve #1514
Resolve #1643
Resolve #1646
Resolve #1666

How has this been tested?

Manually

Checklist

I submit my changes into the develop branch
I have added description of my changes into CHANGELOG file
~~- [ ] I have updated the documentation accordingly~~
~~- [ ] I have added tests to cover my changes~~
I have linked related issues (read github docs)
I have increased versions of npm packages if it is necessary (cvat-canvas,
cvat-core, cvat-data and cvat-ui)

License

I submit my code changes under the same MIT License that covers the project.
Feel free to contact the maintainers if that's a concern.
I have updated the license header for each file (see an example below)

# Copyright (C) 2020 Intel Corporation
#
# SPDX-License-Identifier: MIT

settings moved from page to modal

coveralls · 2020-06-14T23:39:26Z

Pull Request Test Coverage Report for Build 6136

0 of 0 changed or added relevant lines in 0 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage increased (+0.004%) to 65.136%

Files with Coverage Reduction	New Missed Lines	%
cvat/apps/engine/media_extractors.py	1	77.35%

Totals
Change from base Build 6122:	0.004%
Covered Lines:	11006
Relevant Lines:	16486

💛 - Coveralls

cvat-ui/src/components/task-page/details.tsx

cvat-ui/src/components/annotation-page/standard-workspace/objects-side-bar/object-item.tsx

cvat-ui/src/components/annotation-page/standard-workspace/styles.scss

cvat-ui/src/components/cvat-app.tsx

cvat-ui/src/components/header/settings-modal/player-settings.tsx

bsekachev · 2020-06-17T14:54:15Z

When I press F2 (whenever I am), CVAT goes to dashboard. Settings modal is expected to be opened.
It seems that these settings doesn't work: grid size, show all interpolation tracks, always show object details, auto save (I am not sure here, need to check)
It would be great to remove extra white space on settings modal:

CHANGELOG.md

cvat-ui/src/components/annotation-page/standard-workspace/objects-side-bar/objects-side-bar.tsx

CHANGELOG.md

bsekachev · 2020-06-23T05:28:02Z

The issue persists
Probably need to check event target

cvat-canvas/src/typescript/canvasView.ts

bsekachev · 2020-06-23T05:17:56Z

cvat-ui/src/components/annotation-page/standard-workspace/canvas-wrapper.tsx

+        if (prevProps.showAllInterpolationTracks !== showAllInterpolationTracks) {
+            onFetchAnnotation();
+        }
+


Can we dispatch this action immediately after changing settings?
Here: src/containers/header/settings-modal/workspace-settings.tsx Line 72

@bsekachev, what about example future case when we change value by loading it from server? I think it can be more common way.

@ActiveChooN

I am not sure I understand you. What value? How are we going to get it from the server?
My idea is that now it is not obvious how the action is called after changing showAllInterpolationTracks.

bsekachev · 2020-06-23T05:32:51Z

cvat-ui/src/components/header/settings-modal/workspace-settings.tsx

@@ -42,7 +42,7 @@ export default function WorkspaceSettingsComponent(props: Props): JSX.Element {
        onSwitchAutomaticBordering,
    } = props;

-    const minAutoSaveInterval = 5;
+    const minAutoSaveInterval = 1;


Is it necessary to change or for test only?

@bsekachev, what is preventing us to decrease this parameter? I guess we discussed it sometime.

cvat-ui/src/containers/header/header.tsx

cvat-ui/src/components/header/settings-modal/player-settings.tsx

nmanovic · 2020-06-24T15:55:12Z

Here is an overview of what got changed by this pull request:

Issues
======
- Added 2

See the complete overview on Codacy

nmanovic · 2020-06-24T15:55:21Z

cvat-ui/src/components/header/settings-modal/styles.scss

 }
+
+.cvat-settings-modal .ant-modal-body{


Codacy found an issue: Expected single space before "{" (block-opening-brace-space-before)

nmanovic · 2020-06-24T15:55:22Z

cvat-ui/src/components/header/settings-modal/styles.scss

+
+.cvat-settings-modal .ant-modal-body{
+    padding-top: 0;
+}


Codacy found an issue: Unexpected missing end-of-source newline (no-missing-end-of-source-newline)

ActiveChooN added 8 commits June 1, 2020 16:13

Added image preview on settings page and fixed bugtracker input

07c5b81

A

580e5af

Merge branch 'develop' into dk/batch-of-fixes

a2a8217

added colorpicker library and canvas fix on sidebar closing

5e85f47

added canvas background color picker,

b050eed

settings moved from page to modal

Merge branch 'develop' of https://github.com/opencv/cvat into develop

74a5b9c

Merge branch 'develop' into dk/batch-of-fixes

77efb93

upgraded npm package version

c9f00e1

ActiveChooN requested a review from bsekachev as a code owner June 14, 2020 22:29

ActiveChooN added the enhancement New feature or request label Jun 14, 2020

ActiveChooN added 2 commits June 15, 2020 02:20

fixed paths

eefb702

Added CHANGELOG.md

4101844

ActiveChooN added 3 commits June 15, 2020 13:02

fixed eslint problems

564164e

Merge branch 'develop' of https://github.com/opencv/cvat into develop

5cc2f0b

Merge branch 'develop' into dk/batch-of-fixes

6d1700e

ActiveChooN changed the title ~~CVAT UI: batch of fixes~~ [WIP] CVAT UI: batch of fixes Jun 17, 2020

bsekachev requested changes Jun 17, 2020

View reviewed changes

Fixed show settings shortcut, grid size and bug tracker escape event

9558bf5

bsekachev requested changes Jun 18, 2020

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

cvat-ui/src/components/annotation-page/standard-workspace/objects-side-bar/objects-side-bar.tsx Outdated Show resolved Hide resolved

bsekachev mentioned this pull request Jun 18, 2020

[CVAT-UI] Data annotation team requests and some fixes #1753

Merged

8 tasks

ActiveChooN added 3 commits June 19, 2020 00:54

fixed autosave and settings tabs padding

be7f47f

fixed changelog

0c5911f

fixed CHANGELOG.md

567e518

bsekachev reviewed Jun 19, 2020

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

ActiveChooN added 2 commits June 19, 2020 12:09

Fixed displaying all text

56a5fb1

fixed CHNAGELOG.md

6d15c04

ActiveChooN added 2 commits June 19, 2020 23:15

moved to standart dom transitionend event

3e6d77f

fixed show all interpolation tracks parameter switch

80daa43

ActiveChooN changed the title ~~[WIP] CVAT UI: batch of fixes~~ CVAT UI: batch of fixes Jun 22, 2020

ActiveChooN requested review from bsekachev and nmanovic June 22, 2020 07:51

Merge branch 'develop' into dk/batch-of-fixes

45b09df

bsekachev reviewed Jun 23, 2020

View reviewed changes

ActiveChooN added 2 commits June 23, 2020 16:47

fixed PR

36ec40f

Merge branch 'develop' into dk/batch-of-fixes

86c29fb

bsekachev previously approved these changes Jun 24, 2020

View reviewed changes

Merge branch 'develop' into dk/batch-of-fixes

c87e1af

ActiveChooN dismissed bsekachev’s stale review via c87e1af June 24, 2020 15:52

nmanovic reviewed Jun 24, 2020

View reviewed changes

bsekachev approved these changes Jun 24, 2020

View reviewed changes

bsekachev mentioned this pull request Jun 24, 2020

CVAT new UI: Cannot read property 'annotations' of null #1666

Closed

2 tasks

bsekachev merged commit 49a7ad5 into develop Jun 25, 2020

bsekachev deleted the dk/batch-of-fixes branch June 25, 2020 14:54

frndmg pushed a commit to signatrix/cvat that referenced this pull request Aug 5, 2020

CVAT UI: batch of fixes (cvat-ai#1705)

765a731

snyk-bot mentioned this pull request May 16, 2021

[Snyk] Upgrade react-redux from 7.2.3 to 7.2.4 #3194

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

CVAT UI: batch of fixes #1705

CVAT UI: batch of fixes #1705

ActiveChooN commented Jun 14, 2020 •

edited by bsekachev

Loading

coveralls commented Jun 14, 2020 •

edited

Loading

bsekachev commented Jun 17, 2020

bsekachev commented Jun 23, 2020

bsekachev Jun 23, 2020

ActiveChooN Jun 23, 2020

bsekachev Jun 24, 2020

bsekachev Jun 23, 2020 •

edited

Loading

ActiveChooN Jun 23, 2020

nmanovic commented Jun 24, 2020

nmanovic Jun 24, 2020

nmanovic Jun 24, 2020

		}

		.cvat-settings-modal .ant-modal-body{

CVAT UI: batch of fixes #1705

CVAT UI: batch of fixes #1705

Conversation

ActiveChooN commented Jun 14, 2020 • edited by bsekachev Loading

Motivation and context

How has this been tested?

Checklist

License

coveralls commented Jun 14, 2020 • edited Loading

Pull Request Test Coverage Report for Build 6136

💛 - Coveralls

bsekachev commented Jun 17, 2020

bsekachev commented Jun 23, 2020

bsekachev Jun 23, 2020

Choose a reason for hiding this comment

ActiveChooN Jun 23, 2020

Choose a reason for hiding this comment

bsekachev Jun 24, 2020

Choose a reason for hiding this comment

bsekachev Jun 23, 2020 • edited Loading

Choose a reason for hiding this comment

ActiveChooN Jun 23, 2020

Choose a reason for hiding this comment

nmanovic commented Jun 24, 2020

nmanovic Jun 24, 2020

Choose a reason for hiding this comment

nmanovic Jun 24, 2020

Choose a reason for hiding this comment

ActiveChooN commented Jun 14, 2020 •

edited by bsekachev

Loading

coveralls commented Jun 14, 2020 •

edited

Loading

bsekachev Jun 23, 2020 •

edited

Loading