Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed default undefined, fixed double change #1935

Merged
merged 2 commits into from
Jul 28, 2020
Merged

Conversation

bsekachev
Copy link
Member

Switch source when change zOrder, occluded, outside, keyframe since they are part of position
Fixed double undo/redo actions on every change
Fixed undefined source on client

Motivation and context

Some fixes for recent PR #1192

How has this been tested?

Manual testing

Checklist

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below)
# Copyright (C) 2020 Intel Corporation
#
# SPDX-License-Identifier: MIT

@bsekachev bsekachev added the bug Something isn't working label Jul 24, 2020
@coveralls
Copy link

coveralls commented Jul 24, 2020

Pull Request Test Coverage Report for Build 6606

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 211 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+0.04%) to 64.984%

Files with Coverage Reduction New Missed Lines %
cvat/apps/engine/media_extractors.py 1 75.81%
src/object-state.js 10 87.01%
src/annotations-objects.js 200 62.02%
Totals Coverage Status
Change from base Build 6575: 0.04%
Covered Lines: 11096
Relevant Lines: 16673

💛 - Coveralls

@nmanovic
Copy link
Contributor

@Priya4607 , could you please test and review the patch?

@Priya4607
Copy link
Contributor

@Priya4607 , could you please test and review the patch?

Sure, I'll test it this weekend.

@Priya4607
Copy link
Contributor

@bsekachev
Hi, one quick question, how does switching source in case of occluded, keyframe, outside work. As in when I switch to occlusion for an auto annotated box will it change to manual?

@bsekachev
Copy link
Member Author

Hi, one quick question, how does switching source in case of occluded, keyframe, outside work. As in when I switch to occlusion for an auto annotated box will it change to manual?

Yes

@Priya4607
Copy link
Contributor

Hi, one quick question, how does switching source in case of occluded, keyframe, outside work. As in when I switch to occlusion for an auto annotated box will it change to manual?

Yes

But when I switch occluded for auto annotated box, I notice that the value does not change to manual. Unless I move the box.

@bsekachev
Copy link
Member Author

@Priya4607

Hmm, yes. Actually I checked it only for tracks. Now it is fixed.

@bsekachev bsekachev merged commit 1d17647 into develop Jul 28, 2020
@bsekachev bsekachev deleted the bs/fixed_source branch July 29, 2020 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants