Batch of fixes

CHANGELOG.md

@@ -23,6 +23,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 ### Fixed
 - Issue loading openvino models for semi-automatic and automatic annotation (<https://github.com/opencv/cvat/pull/1996>)
 - Basic functions of CVAT works without activated nuclio dashboard
+- Fixed error with creating task with labels with the same name (<https://github.com/opencv/cvat/pull/2031>)
 
 ### Security
 -

cvat-ui/package.json

@@ -1,6 +1,6 @@
 {
   "name": "cvat-ui",
-  "version": "1.7.1",
+  "version": "1.7.2",
   "description": "CVAT single-page application",
   "main": "src/index.tsx",
   "scripts": {

cvat-ui/src/components/labels-editor/constructor-creator.tsx

@@ -8,14 +8,15 @@ import LabelForm from './label-form';
 import { Label } from './common';
 
 interface Props {
+    labelNames: string[];
     onCreate: (label: Label | null) => void;
 }
 
 export default function ConstructorCreator(props: Props): JSX.Element {
-    const { onCreate } = props;
+    const { onCreate, labelNames } = props;
     return (
         <div className='cvat-label-constructor-creator'>
-            <LabelForm label={null} onSubmit={onCreate} />
+            <LabelForm label={null} onSubmit={onCreate} labelNames={labelNames} />
         </div>
     );
 }

cvat-ui/src/components/labels-editor/label-form.tsx

@@ -32,6 +32,7 @@ export enum AttributeType {
 
 type Props = FormComponentProps & {
     label: Label | null;
+    labelNames?: string[];
     onSubmit: (label: Label | null) => void;
 };
 
@@ -384,6 +385,7 @@ class LabelForm extends React.PureComponent<Props, {}> {
         const {
             label,
             form,
+            labelNames,
         } = this.props;
         const value = label ? label.name : '';
         const locked = label ? label.id >= 0 : false;
@@ -399,6 +401,13 @@ class LabelForm extends React.PureComponent<Props, {}> {
                         }, {
                             pattern: patterns.validateAttributeName.pattern,
                             message: patterns.validateAttributeName.message,
+                        }, {
+                            validator:
+                                async (_rule: any, labelName: string, callback: Function) => {
+                                    if (labelNames && labelNames.includes(labelName)) {
+                                        callback('Label name must be unique for the task');
+                                    }
+                                },
                         }],
                     })(<Input disabled={locked} placeholder='Label name' />)}
                 </Form.Item>

cvat-ui/src/components/labels-editor/labels-editor.tsx

@@ -221,6 +221,7 @@ export default class LabelsEditor
     }
 
     public render(): JSX.Element {
+        const { labels } = this.props;
         const {
             savedLabels,
             unsavedLabels,
@@ -319,6 +320,7 @@ export default class LabelsEditor
                         constructorMode === ConstructorMode.CREATE
                             && (
                                 <ConstructorCreator
+                                    labelNames={labels.map((l) => l.name)}
                                     onCreate={this.handleCreate}
                                 />
                             )

cvat-ui/src/components/labels-editor/raw-viewer.tsx

@@ -28,6 +28,10 @@ class RawViewer extends React.PureComponent<Props> {
             if (!Array.isArray(parsed)) {
                 callback('Field is expected to be a JSON array');
             }
+            const labelNames = parsed.map((label: Label) => label.name);
+            if (new Set(labelNames).size !== labelNames.length) {
+                callback('Label names must be unique for the task');
+            }
 
             for (const label of parsed) {
                 try {

cvat/apps/engine/serializers.py

@@ -37,6 +37,7 @@ def to_representation(self, instance):
 class LabelSerializer(serializers.ModelSerializer):
     attributes = AttributeSerializer(many=True, source='attributespec_set',
         default=[])
+
     class Meta:
         model = models.Label
         fields = ('id', 'name', 'attributes')
@@ -305,6 +306,12 @@ def update(self, instance, validated_data):
         instance.save()
         return instance
 
+    def validate_labels(self, data):
+        label_names = [label['name'] for label in data]
+        if len(label_names) != len(set(label_names)):
+            raise serializers.ValidationError('All label names must be unique for the task')
+
+
 class ProjectSerializer(serializers.ModelSerializer):
     class Meta:
         model = models.Project