Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Datumaro] Mandatory sorting for black color in voc masks #2048

Merged
merged 3 commits into from
Aug 26, 2020

Conversation

zhiltsov-max
Copy link
Contributor

@zhiltsov-max zhiltsov-max commented Aug 18, 2020

Motivation and context

Fixes #2032

  • Removed guess label map type, which combined voc and source labels. Default is set to source.
  • Black color is automatically added. It is automatically sorted to be the first in the list. Default name is background.

How has this been tested?

Unit tests

Checklist

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below)
# Copyright (C) 2020 Intel Corporation
#
# SPDX-License-Identifier: MIT

@coveralls
Copy link

coveralls commented Aug 18, 2020

Pull Request Test Coverage Report for Build 7118

  • 20 of 22 (90.91%) changed or added relevant lines in 2 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.01%) to 69.747%

Changes Missing Coverage Covered Lines Changed/Added Lines %
datumaro/datumaro/plugins/voc_format/converter.py 16 17 94.12%
datumaro/datumaro/plugins/voc_format/format.py 4 5 80.0%
Files with Coverage Reduction New Missed Lines %
datumaro/datumaro/plugins/voc_format/converter.py 1 89.9%
Totals Coverage Status
Change from base Build 7115: 0.01%
Covered Lines: 11754
Relevant Lines: 16396

💛 - Coveralls

azhavoro
azhavoro previously approved these changes Aug 19, 2020
nmanovic
nmanovic previously approved these changes Aug 26, 2020
Copy link
Contributor

@nmanovic nmanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nmanovic nmanovic dismissed stale reviews from azhavoro and themself via 49254ad August 26, 2020 14:25
@nmanovic nmanovic merged commit 55073fb into develop Aug 26, 2020
@nmanovic nmanovic deleted the zm/fix-mask-label-order branch August 26, 2020 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect order of labels in the exported masks
4 participants