Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PDF reading - part 1 #2141

Merged
merged 2 commits into from
Sep 9, 2020
Merged

Fix PDF reading - part 1 #2141

merged 2 commits into from
Sep 9, 2020

Conversation

zhiltsov-max
Copy link
Contributor

Motivation and context

Fixes #2139

How has this been tested?

Manual test

Checklist

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below)
# Copyright (C) 2020 Intel Corporation
#
# SPDX-License-Identifier: MIT

@nmanovic
Copy link
Contributor

nmanovic commented Sep 7, 2020

Please add a line into CHANGELOG as well.

  File "/home/django/cvat/apps/engine/views.py", line 46, in <module>
35129    from . import models, task
35130  File "/home/django/cvat/apps/engine/task.py", line 314
35131    elif isinstance(extractor, (MEDIA_TYPES['zip']['extractor'], MEDIA_TYPES['pdf']['extractor'])):
35132    ^
35133SyntaxError: invalid syntax

@zhiltsov-max zhiltsov-max changed the title Fix PDF reading [WIP] Fix PDF reading Sep 8, 2020
@zhiltsov-max
Copy link
Contributor Author

zhiltsov-max commented Sep 8, 2020

WIP - Will fail after the first interpreter exit.

@zhiltsov-max zhiltsov-max changed the title [WIP] Fix PDF reading Fix PDF reading - part 1 Sep 8, 2020
@zhiltsov-max zhiltsov-max mentioned this pull request Sep 8, 2020
8 tasks
nmanovic
nmanovic previously approved these changes Sep 9, 2020
@nmanovic nmanovic merged commit 8d3c95a into develop Sep 9, 2020
@nmanovic nmanovic deleted the zm/fix-pdf-reading branch September 9, 2020 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pdf support was broken
2 participants