Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add auto inference of host scheme in CLI #2240

Merged
merged 3 commits into from
Oct 3, 2020
Merged

Conversation

zhiltsov-max
Copy link
Contributor

Motivation and context

Resolves openvinotoolkit/datumaro#30

  • Added auto inference of host url schema in CLI, if it is provided in the url

How has this been tested?

Manual test

Checklist

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below)
# Copyright (C) 2020 Intel Corporation
#
# SPDX-License-Identifier: MIT

@coveralls
Copy link

coveralls commented Sep 29, 2020

Coverage Status

Coverage decreased (-0.01%) to 64.8% when pulling 990f61d on zm/cli-infer-host-schema into 5052737 on develop.

@nmanovic nmanovic merged commit f138859 into develop Oct 3, 2020
@nmanovic nmanovic deleted the zm/cli-infer-host-schema branch October 3, 2020 04:46
@@ -182,8 +182,13 @@ class CVAT_API_V1():
""" Build parameterized API URLs """

def __init__(self, host, https=False):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You may drop the 'https' argument from function declaration, aren't you?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a parameter in CLI to enforce https, which uses this function parameter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DNS Resolution Issue with Datumaro 1.0 exported from CVAT
5 participants