Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dependent] Simple Review Pipeline (Client) #2357

Merged
merged 123 commits into from
Dec 1, 2020
Merged

Conversation

bsekachev
Copy link
Member

@bsekachev bsekachev commented Oct 26, 2020

Motivation and context

Depends on #2338
Resolved #2082
Related #1100

How has this been tested?

Checklist

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below)
# Copyright (C) 2020 Intel Corporation
#
# SPDX-License-Identifier: MIT

@nmanovic
Copy link
Contributor

I got the error below. Try to assign an issue on an object and after that remove the object. Go to next frame with an object.

TypeError
Cannot read property 'label' of undefined

TypeError: Cannot read property 'label' of undefined
    at Function.mapToProps (http://localhost:8080/cvat-ui.4ab42c810efc6fc7738e.min.js:365:1027292)
    at a (http://localhost:8080/cvat-ui.4ab42c810efc6fc7738e.min.js:365:465545)
    at Function.a.mapToProps (http://localhost:8080/cvat-ui.4ab42c810efc6fc7738e.min.js:365:465682)
    at a (http://localhost:8080/cvat-ui.4ab42c810efc6fc7738e.min.js:365:465545)
    at http://localhost:8080/cvat-ui.4ab42c810efc6fc7738e.min.js:365:466910
    at http://localhost:8080/cvat-ui.4ab42c810efc6fc7738e.min.js:365:464319
    at Object.useMemo (http://localhost:8080/cvat-ui.4ab42c810efc6fc7738e.min.js:341:62782)
    at t.useMemo (http://localhost:8080/cvat-ui.4ab42c810efc6fc7738e.min.js:325:5984)
    at d (http://localhost:8080/cvat-ui.4ab42c810efc6fc7738e.min.js:365:464263)
    at qo (http://localhost:8080/cvat-ui.4ab42c810efc6fc7738e.min.js:341:57930)

@bsekachev
Copy link
Member Author

@nmanovic

I found another way to reproduce a bit, but anyway should be fixed now.

@bsekachev
Copy link
Member Author

@nmanovic @ActiveChooN
So, the patch looks quite stable. At least I do not see any critical issues any more

@nmanovic
Copy link
Contributor

nmanovic commented Dec 1, 2020

@bsekachev , I will review right now and merge if I don't see any issues.

@nmanovic nmanovic merged commit d6ac8cc into develop Dec 1, 2020
@nmanovic nmanovic deleted the bs/review_pipeline_2 branch December 1, 2020 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Find a better place to job status switcher
4 participants