Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ImageNet format #2376

Merged
merged 2 commits into from
Nov 5, 2020
Merged

Add ImageNet format #2376

merged 2 commits into from
Nov 5, 2020

Conversation

yasakova-anastasia
Copy link
Contributor

@yasakova-anastasia yasakova-anastasia commented Oct 30, 2020

Motivation and context

Add ImageNet format support

How has this been tested?

Unit tests

Checklist

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below)
# Copyright (C) 2020 Intel Corporation
#
# SPDX-License-Identifier: MIT

@coveralls
Copy link

Coverage Status

Coverage increased (+0.04%) to 60.703% when pulling a38b10e on ay/add-imagenet into 373d94c on develop.

Copy link
Contributor

@zhiltsov-max zhiltsov-max left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The bindings are OK, but there is an issue in formats:

  • imagenet collects all labels form all annotations on an image. This line can fail, if an annotation does not have .label field. Txt is correct.

The behaviour is expected, however. I think, we probably should add a transform for collecting all labels, or a converter parameter to do this. Such a transform should be run before exporting.

@nmanovic nmanovic merged commit 3b29621 into develop Nov 5, 2020
@nmanovic nmanovic deleted the ay/add-imagenet branch November 5, 2020 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants