Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issue: Cannot read property label of undefined #2442

Merged
merged 3 commits into from
Nov 17, 2020

Conversation

bsekachev
Copy link
Member

Motivation and context

Resolve #1823

How has this been tested?

Manual testing
@dvkruchinin Could you please write a test for the issue?

Scenario is quite interesting, so, probably need to think how implement the test better.

  1. First we need a task with at least two images and chunk size === 1 (there can be other conditions, but anyway during the test we need to fetch another chunk. In this simplest way it is achieved just by jumping to the next frame)
  2. On the first frame need to create a shape
  3. Next we need to go to another frame (chunk fetching procedure must be run [circle loading progress bar at the center of canvas, element #cvat_canvas_loading_circle])
  4. During this procedure (duration depends on client-server bandwidth) need to open context menu for a shape
  5. Before fix UI is expected to be crashed with this exception

Checklist

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below)
# Copyright (C) 2020 Intel Corporation
#
# SPDX-License-Identifier: MIT

@bsekachev bsekachev added bug Something isn't working need test labels Nov 16, 2020
@dvkruchinin
Copy link
Contributor

Sure. The test will be written.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.02%) to 62.811% when pulling c0d92ed on bs/fixed_issue_1823 into a9b2817 on develop.

ActiveChooN
ActiveChooN previously approved these changes Nov 17, 2020
@bsekachev bsekachev merged commit 414f011 into develop Nov 17, 2020
@bsekachev bsekachev deleted the bs/fixed_issue_1823 branch November 17, 2020 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot read property 'label' of undefined
4 participants