Cypress test. Delete unlock and lock object. #2526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bsekachev
requested changes
Dec 6, 2020
| }; | ||
|
|
||
| function clickRemoveOnDropdownMenu() { | ||
| cy.get('.ant-dropdown') |
There was a problem hiding this comment.
.ant-dropdown is too abstract. Please, use another selector. You can add any css classes to the application (i.e. .cvat-object-item-menu)
There was a problem hiding this comment.
All cssSelectors replaced from "ant*" to "cvat*"
| }; | ||
|
|
||
| function actionOnConfirmWindow(textBuntton) { | ||
| cy.get('.ant-modal-confirm').within(() => { |
There was a problem hiding this comment.
The same comment.
Please, avoid using ant-* classes because they can be changed in other antd versions.
| function checkFailDeleteLockObject(shortcut) { | ||
| deleteObjectViaShortcut(shortcut, 'lock'); | ||
| checkExistObject('exist'); | ||
| cy.get('.ant-notification-topRight').should('exist'); |
…nlock_lock_object
DmitriyOparin
changed the title
DmitriyOparin
changed the title
bsekachev
approved these changes
Dec 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cypress test. Delete unlock and lock object.
Add cssSelectors for elements.
Motivation and context
How has this been tested?
Checklist
developbranchcvat-core, cvat-data and cvat-ui)
License
Feel free to contact the maintainers if that's a concern.