-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added CI workflow to publish CVAT images #2766
Conversation
Co-authored-by: Nikita Manovich <nikita.manovich@intel.com>
@azhavoro , don't forget to add news into CHANGELOG.md |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's change comments for ffmpeg code and add info to CHANGELOG. Great job!
@azhavoro , also need to fix codacy issues. |
@azhavoro , any updates? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job! I didn't test it, just reviewed the code. For me it looks fine.
@azhavoro , could you please notify all stakeholders about the achievement (gitter, Intel teams)? Need to clear emphasize why it is important (speed of the build, easy to deploy, alternative channel to distribute CVAT, etc). |
Sure |
* Configured CI workflow for public images * updated license headers * align list item indent rule for remarklint and prettier * updated changelog Co-authored-by: Nikita Manovich <nikita.manovich@intel.com>
Motivation and context
resolve #7
How has this been tested?
Manually
Checklist
develop
branch- [ ] I have added tests to cover my changes- [ ] I have increased versions of npm packages if it is necessary (cvat-canvas,cvat-core, cvat-data and cvat-ui)
License
Feel free to contact the maintainers if that's a concern.