Cypress. Fix case "Image rotate" for Firefox. #2857
Conversation
| @@ -31,7 +32,8 @@ context('Check if the image is rotated', () => { | |||
| .then(($styles) => { | |||
| scaleAfter = Number($styles.match(/scale\((\d\.\d+)\)/m)[1]); | |||
| cy.expect(scaleBefore).to.be.greaterThan(scaleAfter); | |||
| cy.get('#cvat_canvas_content').dblclick(); | |||
| cy.get('#cvat_canvas_content').dblclick().wait(500); | |||
There was a problem hiding this comment.
Reduced the waiting time. Also separated this behavior depending on the browser. This time was revealed when checking the passing of the test in CI when using the Firefox browser. At the moment, the Cypress repository has an open issue on the issue of different test results in the Firefox browser in headless mode and without it. cypress-io/cypress#8610
If necessary, can I open a separate issue and specify the CVAT repository to reproduce the error?
…o dkru/cypress-case-5-image-rotate-fix-for-firefox
dvkruchinin
force-pushed
the
dkru/cypress-case-5-image-rotate-fix-for-firefox
branch
from
7cd7e9b
to
ca6eeff
Compare
|
What is wrong with this test? It works for me in current implementation (Firefox 85, headless, antd 4.12). |
This test does not always fail. But in CI-nightly, it is steadily falling. I will try to consider other solutions. |
…o dkru/cypress-case-5-image-rotate-fix-for-firefox
Add an additional click on the canvas for hide the popover.
|
Re-worked the test. Removed wait() and added an extra click on the canvas to hide the popover before scaling the image. |
|
Great, thanks! |
Motivation and context
Patches are designed to solve the error
when running the test by Firefox with headless mode.
Link to check: https://github.com/dvkruchinin/cvat/actions/runs/595622158
How has this been tested?
Checklist
developbranchcvat-core, cvat-data and cvat-ui)
License
Feel free to contact the maintainers if that's a concern.