-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for Market-1501 dataset format #2869
Conversation
@yasakova-anastasia , there are some problems with tests:
|
@nmanovic , this PR depends on openvinotoolkit/datumaro#102, openvinotoolkit/datumaro#108 and openvinotoolkit/datumaro#114, so the tests fail. |
dataset = Dataset.from_extractors(CvatTaskDataExtractor( | ||
task_data, include_images=save_images), env=dm_env) | ||
with TemporaryDirectory() as temp_dir: | ||
for item in dataset._data._source: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should not be done this way, use transform for this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I couldn't find transform for this task. What should I use here?
task_data, include_images=save_images), env=dm_env) | ||
with TemporaryDirectory() as temp_dir: | ||
dataset.transform(LabelAttrToAttr, 'market-1501') | ||
dataset.export(temp_dir, 'market1501', save_images=save_images) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In future, it would be nice to provide an option to choose the label. Maybe, we should check for and use the only existing label in the task?
Motivation and context
Add support for Market-1501 dataset format
Depends on openvinotoolkit/datumaro#102, openvinotoolkit/datumaro#108 and openvinotoolkit/datumaro#114
How has this been tested?
Unit tests
Checklist
develop
branchcvat-core, cvat-data and cvat-ui)
License
Feel free to contact the maintainers if that's a concern.