Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Label form validator fix #2879

Merged
merged 3 commits into from
Mar 1, 2021
Merged

Label form validator fix #2879

merged 3 commits into from
Mar 1, 2021

Conversation

ActiveChooN
Copy link
Contributor

@ActiveChooN ActiveChooN commented Feb 28, 2021

Motivation and context

This PR fix label form validator to prevent creating labels with the same name.

How has this been tested?

Manually.
@dvkruchinin, can you change test case 43 appropriate way to check form item validator additionally, please?

Checklist

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below)
# Copyright (C) 2021 Intel Corporation
#
# SPDX-License-Identifier: MIT

@ActiveChooN ActiveChooN added bug Something isn't working need test labels Feb 28, 2021
@dvkruchinin
Copy link
Contributor

@ActiveChooN

can you change test case 43 appropriate way to check form item validator additionally

Sure. I will prepare PR to this branch.

@bsekachev bsekachev requested review from vnishukov and removed request for bsekachev March 1, 2021 06:03
@bsekachev
Copy link
Member

@vnishukov Please, review the PR

@dvkruchinin
Copy link
Contributor

@ActiveChooN
Is the correct behavior that after clicking on the Done button, the notification in the form of a pop-up window should now not appear?

vnishukov
vnishukov previously approved these changes Mar 1, 2021
Copy link
Contributor

@vnishukov vnishukov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to fix failed e2e tests

…R 2879 (#2883)

* Fix case 43 for PR 2879

* Try restart CI
@bsekachev bsekachev merged commit c793baf into develop Mar 1, 2021
@bsekachev bsekachev deleted the dk/fix-creating-exact-labels branch March 1, 2021 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants