Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed: Cannot update attributes if a task contain at least one number attribute #2969

Merged
merged 3 commits into from
Mar 18, 2021

Conversation

bsekachev
Copy link
Member

@bsekachev bsekachev commented Mar 17, 2021

Motivation and context

Resolved #2968

How has this been tested?

Checklist

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below)
# Copyright (C) 2021 Intel Corporation
#
# SPDX-License-Identifier: MIT

@bsekachev
Copy link
Member Author

Hi, @dvkruchinin

Could you please update a task with attributes editing? (I believe we have similar, but maybe they do not cover this case)

@bsekachev bsekachev changed the title Resolved issue #2968 Fixed: Cannot update attributes if a task contain at least one number attribute Mar 17, 2021
@dvkruchinin
Copy link
Contributor

dvkruchinin commented Mar 17, 2021

Could you please update a task with attributes editing? (I believe we have similar, but maybe they do not cover this case)

Sure. I`ll check and prepare a PR.

@coveralls
Copy link

coveralls commented Mar 17, 2021

Coverage Status

Coverage increased (+1.6%) to 75.412% when pulling cf20b07 on bs/fixed_issue_2968 into c58074e on develop.

@bsekachev bsekachev added the bug Something isn't working label Mar 18, 2021
@ActiveChooN
Copy link
Contributor

LGTM. But i have one request not entirely relevant to this PR. Can you change alignment to the top from the center in attributes rows to avoid displaced layout along with a validator message?

@bsekachev
Copy link
Member Author

LGTM. But i have one request not entirely relevant to this PR. Can you change alignment to the top from the center in attributes rows to avoid displaced layout along with a validator message?

Sure. Done.

@bsekachev bsekachev merged commit dacdf37 into develop Mar 18, 2021
@bsekachev bsekachev deleted the bs/fixed_issue_2968 branch March 18, 2021 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot update attributes if a task contain at least one number attribute
4 participants