Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add is_active field in UserFilter #3235

Merged
merged 5 commits into from
Jun 1, 2021

Conversation

Jooong
Copy link
Contributor

@Jooong Jooong commented May 25, 2021

Motivation and context

Closes #3183 by adding is_active filter to user list.

How has this been tested?

Tested with api swagger.

Checklist

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below)
# Copyright (C) 2021 Intel Corporation
#
# SPDX-License-Identifier: MIT

@Jooong Jooong requested a review from nmanovic as a code owner May 25, 2021 17:33
Copy link
Contributor

@ActiveChooN ActiveChooN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! Could you also include these changes to the cvat-core here and make the value true by default?
https://github.com/openvinotoolkit/cvat/blob/d14c26a32f35c75a899a0142bf93c81ddf502f4e/cvat-core/src/api-implementation.js#L115-L139

@Jooong Jooong requested a review from bsekachev as a code owner May 26, 2021 15:42
@Jooong Jooong force-pushed the add_user_is_active_filter branch from 71b4d94 to 07ae037 Compare May 26, 2021 15:56
@Jooong
Copy link
Contributor Author

Jooong commented May 26, 2021

Sure, added a commit regarding cvat-core.

@ActiveChooN
Copy link
Contributor

@dvkruchinin, looks like review pipeline tests failed, can take a look, please?

@dvkruchinin
Copy link
Contributor

@ActiveChooN

looks like review pipeline tests failed, can take a look, please?

Sure. I`ll take a look.

@dvkruchinin
Copy link
Contributor

@ActiveChooN
The user's search query has changed.
In the file tests/cypress/support/commands_review_pipeline.js
need to replace the line number 160 to
cy.intercept('GET', `/api/v1/users?is_active=true&search=${user}&limit=10`).as('searchUsers');

@Jooong Jooong requested a review from azhavoro as a code owner May 28, 2021 09:32
@Jooong
Copy link
Contributor Author

Jooong commented May 28, 2021

@ActiveChooN
The user's search query has changed.
In the file tests/cypress/support/commands_review_pipeline.js
need to replace the line number 160 to
cy.intercept('GET', `/api/v1/users?is_active=true&search=${user}&limit=10`).as('searchUsers');

Also pushed this fix.

ActiveChooN
ActiveChooN previously approved these changes May 28, 2021
Copy link
Contributor

@ActiveChooN ActiveChooN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

CHANGELOG.md Outdated Show resolved Hide resolved
@bsekachev bsekachev merged commit 573bdbe into cvat-ai:develop Jun 1, 2021
@bsekachev
Copy link
Member

Thanks for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inactive users in users list
5 participants