Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed cvat_ui image build in case of OOM error #3379

Merged
merged 2 commits into from
Jul 1, 2021

Conversation

azhavoro
Copy link
Contributor

@azhavoro azhavoro commented Jun 30, 2021

Fixed cvat_ui image build in case of OOM error.
There seems to be a bug in npm v6.x with signal handling on alpine based images only npm/cli#2103 and it won't be fixed for v6.x. This bug is not reproducible on debian buster based images and is not reproducible for npm v 7.x.
We are currently unable to switch to npm 7 easily, so I suggest using a buster based image as the first stage.

Motivation and context

resolve #2989

How has this been tested?

Previously, building the image with the following command docker build --memory 500M -f Dockerfile.ui . was successful, although npm run build was killed; for now it handles correctly

Checklist

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below)
# Copyright (C) 2021 Intel Corporation
#
# SPDX-License-Identifier: MIT

@nmanovic
Copy link
Contributor

@azhavoro , need to add a line to CHANGELOG.md

@nmanovic nmanovic merged commit 7f4b185 into develop Jul 1, 2021
@nmanovic nmanovic deleted the az/fix_cvat_ui_build branch July 1, 2021 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Welcome to nginx?
2 participants