Fixed cvat_ui image build in case of OOM error #3379
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed cvat_ui image build in case of OOM error.
There seems to be a bug in npm v6.x with signal handling on alpine based images only npm/cli#2103 and it won't be fixed for v6.x. This bug is not reproducible on debian buster based images and is not reproducible for npm v 7.x.
We are currently unable to switch to npm 7 easily, so I suggest using a buster based image as the first stage.
Motivation and context
resolve #2989
How has this been tested?
Previously, building the image with the following command
docker build --memory 500M -f Dockerfile.ui .
was successful, althoughnpm run build
was killed; for now it handles correctlyChecklist
develop
branch- [ ] I have updated the documentation accordingly- [ ] I have added tests to cover my changes- [ ] I have increased versions of npm packages if it is necessary (cvat-canvas,cvat-core, cvat-data and cvat-ui)
License
Feel free to contact the maintainers if that's a concern.