Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Open Images format #3679

Merged
merged 16 commits into from
Nov 9, 2021
Merged

Add Open Images format #3679

merged 16 commits into from
Nov 9, 2021

Conversation

sizov-kirill
Copy link
Contributor

@sizov-kirill sizov-kirill commented Sep 16, 2021

Motivation and context

How has this been tested?

Checklist

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below)
# Copyright (C) 2021 Intel Corporation
#
# SPDX-License-Identifier: MIT

@sizov-kirill sizov-kirill marked this pull request as ready for review October 29, 2021 10:24
zhiltsov-max
zhiltsov-max previously approved these changes Nov 1, 2021
Copy link
Contributor

@zhiltsov-max zhiltsov-max left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review the implementation wrt #3790

for row in desc:
yield row.split(',')[0]

@exporter(name='Open Images', ext='ZIP', version='1.0')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe, we should be more specific about the version and add v6.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

zhiltsov-max
zhiltsov-max previously approved these changes Nov 8, 2021
@nmanovic
Copy link
Contributor

nmanovic commented Nov 8, 2021

@kirill-sizov , image meta information is provided only for annotatated images. Is it expected?
I have approximately 200 images in my task. I have annotated 9 first frames.

$ cat images.meta
# <image name> <height> <width>

Abyssinian_123 333 500
Abyssinian_71 539 833
Bengal_197 206 300
Birman_128 375 500
Birman_43 500 340
Birman_44 375 500
Birman_82 324 448
Bombay_104 250 167
Bombay_157 849 704

@sizov-kirill
Copy link
Contributor Author

sizov-kirill commented Nov 9, 2021

@kirill-sizov , image meta information is provided only for annotatated images. Is it expected? I have approximately 200 images in my task. I have annotated 9 first frames.

$ cat images.meta
# <image name> <height> <width>

Abyssinian_123 333 500
Abyssinian_71 539 833
Bengal_197 206 300
Birman_128 375 500
Birman_43 500 340
Birman_44 375 500
Birman_82 324 448
Bombay_104 250 167
Bombay_157 849 704

@nmanovic, Yes it's expected, because we need information about image size only for images that have annotation objects.

@nmanovic
Copy link
Contributor

nmanovic commented Nov 9, 2021

@kirill-sizov , image meta information is provided only for annotatated images. Is it expected? I have approximately 200 images in my task. I have annotated 9 first frames.

$ cat images.meta
# <image name> <height> <width>

Abyssinian_123 333 500
Abyssinian_71 539 833
Bengal_197 206 300
Birman_128 375 500
Birman_43 500 340
Birman_44 375 500
Birman_82 324 448
Bombay_104 250 167
Bombay_157 849 704

@nmanovic, Yes it's expected, because we need information about image size only for images that have annotation objects.

I'm not sure I understand "we". Cityscapes dataset can be used by multiple scripts around the world which can rely on the file. What is the answer from the dataset format point of view?

@sizov-kirill
Copy link
Contributor Author

sizov-kirill commented Nov 9, 2021

@kirill-sizov , image meta information is provided only for annotatated images. Is it expected? I have approximately 200 images in my task. I have annotated 9 first frames.

$ cat images.meta
# <image name> <height> <width>

Abyssinian_123 333 500
Abyssinian_71 539 833
Bengal_197 206 300
Birman_128 375 500
Birman_43 500 340
Birman_44 375 500
Birman_82 324 448
Bombay_104 250 167
Bombay_157 849 704

@nmanovic, Yes it's expected, because we need information about image size only for images that have annotation objects.

I'm not sure I understand "we". Cityscapes dataset can be used by multiple scripts around the world which can rely on the file. What is the answer from the dataset format point of view?

The file images.meta is generated by Datumaro to read the dataset more efficiently. The format stores annotations in a normalized form relative to the size of the image. To avoid reading images, Datumaro uses a workaround in the form of this meta file. Original dataset doesn't contain such information.

@nmanovic nmanovic merged commit cc1b819 into develop Nov 9, 2021
@nmanovic nmanovic deleted the sk/add-open-images-format branch November 9, 2021 10:55
@nmanovic nmanovic mentioned this pull request Mar 4, 2022
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants