fixing support for an external postgresql database with helm deployment #3779
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and context
The helm chart documentation describes steps for using your own postgresql database as follows:
When
redis.enabled
is set tofalse
the environment variables are changed in thecvat_backend/deployment.yaml
, but whenpostgresql.enabled
is set tofalse
the postgres environment variables are not changed.I made a small change that reads the settings from the yaml file for the external database.
How has this been tested?
Built with enabled set to
false
without the change and examined the environment variables of thecvat_backend
service. Then applied my changes and rebuilt and re-examined, confirmed the variables were using my settings with my code changes, but did not use my external db settings without my code changes.To check my environment variables I ran:
Also without these changes I was unable to successfully run:
I was getting a database error.
Checklist
develop
branchcvat-core, cvat-data and cvat-ui)
License
Feel free to contact the maintainers if that's a concern.