Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for helm chart #3784

Closed
wants to merge 1 commit into from
Closed

Fixes for helm chart #3784

wants to merge 1 commit into from

Conversation

Keramblock
Copy link
Contributor

@Keramblock Keramblock commented Oct 11, 2021

Motivation and context

When I started to implement helm chart on our k8s I found several forgotten fields and couple minor problem, so here some fixes
closes #3785

How has this been tested?

Tested on our AKS cluster with blob and external psql

Checklist

  • I submit my changes into the develop branch
  • I have added description of my changes into CHANGELOG file
  • I have updated the documentation accordingly
  • I have added tests to cover my changes(No can do)
  • I have linked related issues (read github docs)
  • I have increased versions of npm packages if it is necessary (cvat-canvas,(Not necessary)
    cvat-core, cvat-data and cvat-ui)

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below)

@Keramblock
Copy link
Contributor Author

Hi @azhavoro, sorry for interrupting, but could you please check this pr? It's pretty straightforward and contains just bug fixes after additional testing in prodlike env.

@nmanovic
Copy link
Contributor

@Keramblock , thanks for the contribution. Could you please add a line about the fix into CHANGELOG.md file?

@nmanovic
Copy link
Contributor

nmanovic commented Nov 8, 2021

@Keramblock , thanks for your contribution. Your PR was merged with small modifications: #3880

@nmanovic nmanovic closed this Nov 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix helm tolerations
3 participants