Cypress. Dummy cloud storages. #3988
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o dkru/cypress-case-109-dummy-cloud-storage
Marishka17
reviewed
Dec 7, 2021
tests/cypress/integration/actions_tasks3/case_109_dummy_cloud_storage.js
Outdated
Show resolved
Hide resolved
…o dkru/cypress-case-109-dummy-cloud-storage
Marishka17
requested changes
Dec 8, 2021
tests/cypress/integration/actions_tasks3/case_109_dummy_cloud_storage.js
Outdated
Show resolved
Hide resolved
Comment on lines
+52
to
+57
| cy.intercept('GET', `api/v1/cloudstorages/${id}/status`, status).as('csStatus'); | ||
| cy.intercept( | ||
| 'GET', | ||
| `api/v1/cloudstorages/${id}/preview`, | ||
| { fixture: `${imageFolder}/${image}` }, | ||
| ).as('csPreview'); |
There was a problem hiding this comment.
Would it be better to move these actions into separate commands?
There was a problem hiding this comment.
Then will have to go to the models page 2 times and back in order for the request to work.
tests/cypress/integration/actions_tasks3/case_109_dummy_cloud_storage.js
Show resolved
Hide resolved
tests/cypress/integration/actions_tasks3/case_109_dummy_cloud_storage.js
Outdated
Show resolved
Hide resolved
tests/cypress/integration/actions_tasks3/case_109_dummy_cloud_storage.js
Outdated
Show resolved
Hide resolved
tests/cypress/integration/actions_tasks3/case_109_dummy_cloud_storage.js
Show resolved
Hide resolved
tests/cypress/integration/actions_tasks3/case_109_dummy_cloud_storage.js
Show resolved
Hide resolved
|
@bsekachev, Hi, could you please also take a look at this PR? |
bsekachev
approved these changes
Dec 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and context
Creating dummy cloud storages and checking their fields.
I disabled this test for Firefox due to the lack of unsupported platform module window. This can be finalized, but you will have to spend more time because most likely you will have to finalize other tests.
I also decided to split the variables with dummy parameters into 3 parts for each type of cloud storage. This was done in order to be able to check notifications when creating CS without status and preview.
How has this been tested?
Checklist
developbranchcvat-core, cvat-data and cvat-ui)
License
Feel free to contact the maintainers if that's a concern.